Bug 21502 - Add checks for YAML formatted system preferences to about page
Summary: Add checks for YAML formatted system preferences to about page
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 14576
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-05 13:50 UTC by Josef Moravec
Modified: 2019-02-27 14:13 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 21502: Add check for YAML formatted system preferences to about page (5.00 KB, patch)
2018-10-05 14:03 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check (715 bytes, patch)
2018-10-05 14:04 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21502: Add check for YAML formatted system preferences to about page (5.07 KB, patch)
2018-10-10 15:18 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check (715 bytes, patch)
2018-10-10 15:18 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2018-10-05 13:50:32 UTC

    
Comment 1 Josef Moravec 2018-10-05 14:03:59 UTC
Created attachment 80085 [details] [review]
Bug 21502: Add check for YAML formatted system preferences to about page

So far there are these yaml formatted preferences:
    UpdateNotForLoanStatusOnCheckin
    OpacHiddenItems
    BibtexExportAdditionalFields
    RisExportAdditionalFields
    UpdateItemWhenLostFromHoldList
    MarcFieldsToOrder
    MarcItemFieldsToOrder

Test plan:
1) Add some badly formatted YAML into some of preferences listed above
2) Check the System information tab on About page for appropriate warnings
Comment 2 Josef Moravec 2018-10-05 14:04:03 UTC
Created attachment 80086 [details] [review]
Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check
Comment 3 Owen Leonard 2018-10-05 15:59:20 UTC
I have one line in my  UpdateItemLocationOnCheckin preference:

PROC: APL-PROMO

And I get the message that it is badly-formatted. Shouldn't that pass?
Comment 4 Josef Moravec 2018-10-10 15:18:00 UTC
Created attachment 80360 [details] [review]
Bug 21502: Add check for YAML formatted system preferences to about page

So far there are these yaml formatted preferences:
    UpdateNotForLoanStatusOnCheckin
    OpacHiddenItems
    BibtexExportAdditionalFields
    RisExportAdditionalFields
    UpdateItemWhenLostFromHoldList
    MarcFieldsToOrder
    MarcItemFieldsToOrder

Test plan:
1) Add some badly formatted YAML into some of preferences listed above
2) Check the System information tab on About page for appropriate warnings
Comment 5 Josef Moravec 2018-10-10 15:18:05 UTC
Created attachment 80362 [details] [review]
Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check
Comment 6 Séverine Queune 2019-02-27 11:18:06 UTC
I don't have the 'UpdateItemLocationOnCheckin' preference that Owen mentioned, and no trace on Koha manual.
I don't have alert for the ItemsDeniedRenewal pref, isn't that YAML too ?
Comment 7 Katrin Fischer 2019-02-27 13:18:58 UTC
(In reply to Séverine Queune from comment #6)
> I don't have the 'UpdateItemLocationOnCheckin' preference that Owen
> mentioned, and no trace on Koha manual.
> I don't have alert for the ItemsDeniedRenewal pref, isn't that YAML too ?

Hi Severine, the first will be added by the bug this depends on, so you need to apply both and run updatedatabase.
Comment 8 Séverine Queune 2019-02-27 14:13:15 UTC
(In reply to Katrin Fischer from comment #7)
> (In reply to Séverine Queune from comment #6)
> > I don't have the 'UpdateItemLocationOnCheckin' preference that Owen
> > mentioned, and no trace on Koha manual.
> > I don't have alert for the ItemsDeniedRenewal pref, isn't that YAML too ?
> 
> Hi Severine, the first will be added by the bug this depends on, so you need
> to apply both and run updatedatabase.

Argh... completely missed the dependency, sorry about that...