Bug 21522 - Labels incorrectly inheriting some default Bootstrap style properties
Summary: Labels incorrectly inheriting some default Bootstrap style properties
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-09 15:03 UTC by Owen Leonard
Modified: 2023-06-06 14:20 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
new CSS fix (36.99 KB, image/png)
2018-12-06 15:11 UTC, Victor Grousset/tuxayo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-10-09 15:03:35 UTC
Our global staff client CSS should override more of Bootstrap's default label styling than it does at the moment. This is causing problems because part of the Bootstrap style is "white-space: nowrap" which prevents long text from wrapping. From the mailing list:

"I’ve noticed that there’s a translation too long in french in catalogue/moredetail.pl so it’s unreadable. Cf image.
Is there’s something to change in the code to allow a longer but clearer translation : Accession date -> Date d'entrée dans les collections"

http://lists.koha-community.org/pipermail/koha-devel/2018-October/044845.html
Comment 1 Victor Grousset/tuxayo 2018-11-21 11:42:02 UTC
Is the CSS that you proposed in the mailing list enough to fix this in a patch?
Comment 2 Victor Grousset/tuxayo 2018-11-21 11:45:09 UTC
Thanks for this by the way :) I confirm that it works.

In intranetUserCSS syspref:

// To remove when the following bugzilla ticket will be finished and deployed
// https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522

ol.bibliodetails li {
    clear: left;
}
.label {
    white-space: normal;
    border-radius: 0;
    text-align: left;
    line-height: inherit;
}
Comment 3 Victor Grousset/tuxayo 2018-12-06 15:11:07 UTC
Created attachment 82913 [details]
new CSS fix

The previous intranetUserCSS workaround was causing a minor issue.

Here is a simpler one which doesn't cause the wrapped text to cross the delimiter of the next line.


/* To remove when the following bugzilla ticket will be finished and deployed */
/* https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522 */

body#catalog_moredetail ol.bibliodetails span.label {
    width: 18em;
}
Comment 4 Victor Grousset/tuxayo 2019-02-28 14:59:10 UTC
@Oleonard: Is the visual result okay for you? (attached screenshot)

If so, I can try to add that in Koha's CSS to submit a patch.
Comment 5 Fridolin Somers 2022-07-21 07:39:37 UTC
Still valid ?
Comment 6 Owen Leonard 2023-06-06 14:20:19 UTC
This issue appears to have been fixed. The labels discussed in the original question are now wrapping correctly.