When a print notice letter (for example HOLD) is marked as "HTML message" it is expected for gather_print_notices.pl (with --html) to accept the message content and not escape the html. Since Bug 13618 this is no longer true. batch/print-notices.tt explicitly adds "| html" before inserting the content regardless of the "HTML message" flag. circ/printslip.tt on the other hand, checks the flag and escapes only if plain output is used.
Created attachment 80992 [details] [review] Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618)
I'm trying to sign this one off, but after I apply the patch I receive the following error when running gather_print_notices.pl: Template process failed: undef error - : filter not found at /home/koha/kohaclone/C4/Templates.pm line 122. I'm mystified as to what could be causing it since I can't see anything wrong with your patch. Any ideas?
Created attachment 81503 [details] [review] Bug 21529: (follow-up) USE raw filter In order to be able to make use of the $raw filter, we need to USE it first
Created attachment 81505 [details] [review] Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Created attachment 81545 [details] [review] Bug 21529: (follow-up) USE raw filter In order to be able to make use of the $raw filter, we need to USE it first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81546 [details] [review] Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81885 [details] [review] Bug 21529: (follow-up) USE raw filter In order to be able to make use of the $raw filter, we need to USE it first Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 81886 [details] [review] Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags Replace a wrong html filter with raw. Test plan: Define a HOLD or DISCHARGE notice template, with html tags. Generate them and confirm that html tags are displayed (which restore the existing behaviour prior to bug 13618) Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nick, You are holding this patch for some reason. Perhaps because of the suggested dependency on bug 21679. Please check that: I do not see why they are dependent. Am I missing something ?
I think the dependency is false - I've remove it.
Awesome work all! Pushed to master for 18.11
backported to 18.05 for 18.05.07
(In reply to Lucas Gass from comment #12) > backported to 18.05 for 18.05.07 Why? Did you see the bug on 18.05? Bug 13618 is not in this version so I do not think the bug exists (I did not check). Jenkins is complaining about that one anyway: koha_1 | # Failed test '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt' koha_1 | # at xt/author/valid-templates.t line 141. koha_1 | # plugin error - raw: plugin not found Patch using the raw plugin ([% var | $raw %]) should not be backported as the plugin does not exist in 18.05 (which you may want to consider at some point).
reverted from 18.05