Bug 21547 - Use set_password in opac-passwd and remove sub goodkey
Summary: Use set_password in opac-passwd and remove sub goodkey
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 21178
Blocks: 21992
  Show dependency treegraph
 
Reported: 2018-10-11 09:56 UTC by Marcel de Rooy
Modified: 2018-12-12 16:54 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 21547: Use update_password in opac-passwd and remove sub goodkey (2.94 KB, patch)
2018-10-11 10:07 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 21547: Use update_password in opac-passwd and remove sub goodkey (3.00 KB, patch)
2018-10-11 10:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 21547: Use set_password in opac-passwd and remove sub goodkey (3.04 KB, patch)
2018-10-11 10:48 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 21547: Use set_password in opac-passwd and remove sub goodkey (3.05 KB, patch)
2018-12-05 17:08 UTC, Owen Leonard
Details | Diff | Splinter Review
erg goed! (3.11 KB, patch)
2018-12-05 17:56 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 21547: Use set_password in opac-passwd and remove sub goodkey (3.11 KB, patch)
2018-12-05 17:56 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2018-10-11 09:56:15 UTC

    
Comment 1 Marcel de Rooy 2018-10-11 10:07:10 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2018-10-11 10:19:48 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2018-10-11 10:21:59 UTC
Tomas, care to sign this one ?
Comment 4 Marcel de Rooy 2018-10-11 10:48:50 UTC
Created attachment 80400 [details] [review]
Bug 21547: Use set_password in opac-passwd and remove sub goodkey

Remove sql statement to change password by calling set_password.
Remove sub goodkey by calling C4::Auth::checkpw_hash.
Adding the scalar before param Oldkey (from bug 21036).

Rebased on top of 21178 (using set_password instead of update_password).

Test plan:
Try to change password in OPAC with good and bad pw.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2018-10-11 10:50:08 UTC
(In reply to Marcel de Rooy from comment #3)
> Tomas, care to sign this one ?

Especially since it is now using set_password :)
Note that this is no behavior change, since the sql statement did not touch userid either..
Comment 6 Owen Leonard 2018-12-05 17:08:56 UTC Comment hidden (obsolete)
Comment 7 Tomás Cohen Arazi 2018-12-05 17:56:02 UTC Comment hidden (obsolete)
Comment 8 Tomás Cohen Arazi 2018-12-05 17:56:47 UTC
Created attachment 82883 [details] [review]
Bug 21547: Use set_password in opac-passwd and remove sub goodkey

Remove sql statement to change password by calling set_password.
Remove sub goodkey by calling C4::Auth::checkpw_hash.
Adding the scalar before param Oldkey (from bug 21036).

Rebased on top of 21178 (using set_password instead of update_password).

Test plan:
Try to change password in OPAC with good and bad pw.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Tomás Cohen Arazi 2018-12-05 17:57:07 UTC
erg goed!
Comment 10 Marcel de Rooy 2018-12-06 07:11:38 UTC
(In reply to Tomás Cohen Arazi from comment #9)
> erg goed!

nudo de lenguaje ?

Thx