Bug 21555 - Merging Patrons allows for all patrons to be selected
Summary: Merging Patrons allows for all patrons to be selected
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 18.05
Hardware: All All
: P5 - low enhancement
Assignee: Brendan Lawlor
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-11 23:32 UTC by Kelly McElligott
Modified: 2025-09-09 15:08 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 21555: Disable merge patrons button when using select all (1.44 KB, patch)
2025-09-09 15:07 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2018-10-11 23:32:34 UTC
The feature of merging patrons (bug #9302 ) did include a fail safe, according to the bug, if/when using this feature, the option of "selecting all" patrons from a search was chosen, then the option to merge could not be used.  When testing this feature, if a few patrons were chosen and then "select all" is chosen, the merge feature is still available to use.  If no patrons are chosen and then "select all" is chosen, merge option is not available. 


Test: how it currently works
1. Search for Patrons by Last Name by Letter
2. From this list, choose patron a, patron b, patron c
3. See that merge patron option available
4. Now select all patrons - merge patron option still available

Test: (how it should work)
1. Search for patrons by last name by letter
2.From this list choose patron a, patron b, patron c
3. See that merge patron option avail
4. Now "select all" patrons 
3. See that merge patron option not available (greyed out)
Comment 1 Brendan Lawlor 2025-09-09 15:07:56 UTC
Created attachment 186304 [details] [review]
Bug 21555: Disable merge patrons button when using select all

This patch disables the merge patrons button when select all is clicked.
The button is re-enabled after clicking clear all or manually changing the selection.

To test:
1. Do a patron search
2. Select at least 2 patrons
3. The merge patron button is enabled
4. Click select all
5. The merge patron button is still enabled
6. Apply patch and refresh browser
7. Click select alll
8. The merge patron button is not enabled anymore
9. Change the selection manually
10. Confirm the merge patron button is re-enabled

Sponsored-by: CLAMS