Checkouts can't be sorted correctly by checkout date depending on the dateformat system preference setting. Verfied in 16.11 and 17.11 so far.
To test: - Go to a patron accont with checkouts from different dates - Sort by checkout date and verify if the sequence is correct - Repeat with different dateformat system preference settings (dd.mm.yyy especially) -
Confirmed on master.
Created attachment 80988 [details] [review] Bug 21562: Fix sort by checkout date in the circulation table The sort is done in SQL but resort by DataTables when displaying the results. iDataSort should be used to mimick date_due sort behavior. Test plan: - Check some items out - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, then due date. The sort should be correct for all values of the DateFormat syspref
Created attachment 81090 [details] [review] Bug 21562: Fix sort by checkout date in the circulation table The sort is done in SQL but resort by DataTables when displaying the results. iDataSort should be used to mimick date_due sort behavior. Test plan: - Check some items out - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, then due date. The sort should be correct for all values of the DateFormat syspref Followed test plan, patch works as described and passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 81294 [details] [review] Bug 21562: Fix sort by checkout date in the circulation table The sort is done in SQL but resort by DataTables when displaying the results. iDataSort should be used to mimick date_due sort behavior. Test plan: - Check some items out - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, then due date. The sort should be correct for all values of the DateFormat syspref Followed test plan, patch works as described and passes QA test tool Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
I prefer not to touch this very important part in 17.11.x. Its a minor impact.
*** Bug 18396 has been marked as a duplicate of this bug. ***