Bug 21594 - description in api_keys table needs a DEFAULT value
Summary: description in api_keys table needs a DEFAULT value
Status: RESOLVED DUPLICATE of bug 21597
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-18 10:25 UTC by Nick Clemens
Modified: 2022-03-22 14:49 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21594 - description in api_keys table needs a DEFAULT value (1.34 KB, patch)
2018-10-18 10:35 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2018-10-18 10:25:02 UTC

    
Comment 1 Nick Clemens 2018-10-18 10:35:14 UTC
Created attachment 80801 [details] [review]
Bug 21594 - description in api_keys table needs a DEFAULT value

To test:
1 - You must have dev_install set in your koha-conf
2 - prove -v t/db_dependent/Koha/ApiKeys.t
3 - It fails
4 - prove -v t/db_dependent/Koha/Object.t
5 - It fails
6 - Apply patch
7 - Update database
8 - Re-run tests
9 - They pass?
Comment 2 Jonathan Druart 2018-10-18 12:25:47 UTC
I have proposed a fix without a DB update on bug 21597 comment 11.
We may want to add this change but I would prefer to fix it in .t files instead of adding a new DB update in a rush. Even if it sounds safe. Well, you forgot the  kohastructure.sql change ;)
Comment 3 Jonathan Druart 2022-03-22 14:49:57 UTC
No longer needed I think, bug 21597 has been pushed.

*** This bug has been marked as a duplicate of bug 21597 ***