To test: 1) Place and item on hold. 2) Trigger the hold. 3) Go to request.pl. Notice that priority shows "1" rather than "Waiting", even though it shows as waiting in the Pickup library column.
As is, bug gives a misleading status, and makes it impossible to set back to priority 1.
Caused by bug 19469.
(In reply to Jonathan Druart from comment #2) > Caused by bug 19469. Confirmed.
Created attachment 81130 [details] [review] Bug 21611: Fix priority dropdown for holds To Test: 1 - Find a record 2 - Place several holds some with differing pickup locations 3 - Check in one hold to confirm as waiting 4 - Check another in to set a hold in transit 5 - View the holds queue for the record: /cgi-bin/koha/reserve/request.pl?biblionumber=## 6 - Confirm found holds are incorrect 7 - Apply patch 8 - Reload 9 - Confirm holds look correct 10 - Alter the values of HoldsSplitQueue and HoldsSplitQueueNumbering 11 - Confirm things still look right
Created attachment 81271 [details] [review] Bug 21611: Fix priority dropdown for holds To Test: 1 - Find a record 2 - Place several holds some with differing pickup locations 3 - Check in one hold to confirm as waiting 4 - Check another in to set a hold in transit 5 - View the holds queue for the record: /cgi-bin/koha/reserve/request.pl?biblionumber=## 6 - Confirm found holds are incorrect 7 - Apply patch 8 - Reload 9 - Confirm holds look correct 10 - Alter the values of HoldsSplitQueue and HoldsSplitQueueNumbering 11 - Confirm things still look right Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, Signing Off
Created attachment 81382 [details] [review] Bug 21611: Fix priority dropdown for holds To Test: 1 - Find a record 2 - Place several holds some with differing pickup locations 3 - Check in one hold to confirm as waiting 4 - Check another in to set a hold in transit 5 - View the holds queue for the record: /cgi-bin/koha/reserve/request.pl?biblionumber=## 6 - Confirm found holds are incorrect 7 - Apply patch 8 - Reload 9 - Confirm holds look correct 10 - Alter the values of HoldsSplitQueue and HoldsSplitQueueNumbering 11 - Confirm things still look right Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Cause not in 18.05.x series.