There is a syntax error in the default notice template for the stock rotation feature.
Created attachment 81109 [details] [review] Bug 21656: Fix for bad TT syntax in default stock rotation notice
Created attachment 81181 [details] [review] Bug 21656: Followup to fix atomicupdate The atomicupdate is going to run as part of an upgrade. It needs to UPDATE, not INSERT. Also, the atomicupdate was numbered incorrectly.
Confirmed that it should be '!=' and not 'ne' like it currently is. http://www.template-toolkit.org/docs/manual/Directives.html#section_IF_UNLESS_ELSIF_ELSE
Created attachment 81185 [details] [review] Bug 21656: Fix for bad TT syntax in default stock rotation notice Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81186 [details] [review] Bug 21656: Followup to fix atomicupdate The atomicupdate is going to run as part of an upgrade. It needs to UPDATE, not INSERT. Also, the atomicupdate was numbered incorrectly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81187 [details] [review] Bug 21656: Reduce the risk of possible side-effects Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81188 [details] [review] Bug 21656: Update 4 missing sample_notices.sql Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #7) > Created attachment 81188 [details] [review] [review] > Bug 21656: Update 4 missing sample_notices.sql Martin, Count on me to repeat that to Italian, Canadian French, French and Norwegian people!
FAIL installer/data/mysql/atomicupdate/bug_21620.perl FAIL git manipulation The file has been added and deleted in the same patchset
Ack, sorry Jonathan... I hadn't appreciated that 'mandatory' has been translated in the directory names!
Created attachment 81275 [details] [review] Bug 21656: Fix for bad TT syntax in default stock rotation notice Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81276 [details] [review] Bug 21656: Followup to fix atomicupdate The atomicupdate is going to run as part of an upgrade. It needs to UPDATE, not INSERT. Also, the atomicupdate was numbered incorrectly. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 81277 [details] [review] Bug 21656: Reduce the risk of possible side-effects Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 81278 [details] [review] Bug 21656: Update 4 missing sample_notices.sql Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Tested the followups and signed off as working.. thankyou chaps.
(In reply to Marcel de Rooy from comment #9) > FAIL installer/data/mysql/atomicupdate/bug_21620.perl > FAIL git manipulation > The file has been added and deleted in the same patchset Not blocker for atomic update I'd say, even if is would be better to amend the first patch and rename it (not a bit deal, really).
We need 21682 signed off first.
QA: Looking here
Created attachment 81868 [details] [review] Bug 21656: Fix for bad TT syntax in default stock rotation notice Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 81869 [details] [review] Bug 21656: (follow-up) Fix atomicupdate The atomicupdate is going to run as part of an upgrade. It needs to UPDATE, not INSERT. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 81870 [details] [review] Bug 21656: Reduce the risk of possible side-effects Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 81871 [details] [review] Bug 21656: Update 4 missing sample_notices.sql Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Jonathan Druart from comment #16) > (In reply to Marcel de Rooy from comment #9) > > FAIL installer/data/mysql/atomicupdate/bug_21620.perl > > FAIL git manipulation > > The file has been added and deleted in the same patchset > > Not blocker for atomic update I'd say, even if is would be better to amend > the first patch and rename it (not a bit deal, really). Fixed that. Made QA tools happy now :)
* Commit title does not contain 'follow-up' correctly spelt - 32bf113 Renamed it. But this was bit arbitrary..
Thanks for the follow-up fixes.. think my brain was on a go slow that day.
Awesome work all! Pushed to master for 18.11
Bug 21682 not in 18.05.x series.