The dataurl variable is already escaped, so the uri filter breaks it. To test: - Search for a record in staff - Go to holds - Search for patrons, multiple should be displayed - Pick a patron by clicking on the name - Verify an error is shown and the URL is incorrect
Created attachment 81375 [details] [review] Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again The uri filter breaks the dataurl variable in the template and the URL is incorrect with it. To test: - Search for a record in staff - Go to holds - Search for patrons, multiple should be displayed - Pick a patron by clicking on the name - Verify an error is shown and the URL is incorrect - Apply patch - Repeat test above, placing a hold should now work. https://bugs.koha-community.org/show_bug.cgi?id=21413
At first glance I'd say the filter should be 'url'.
Can you explain?
I am wondering if the & in the URL above is correct.
Created attachment 81402 [details] [review] Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again We must not encode & again and use the url filter, instead of uri. To test: - Search for a record in staff - Go to holds - Search for patrons, multiple should be displayed - Pick a patron by clicking on the name - Verify an error is shown and the URL is incorrect - Apply patch - Repeat test above, placing a hold should now work.
Created attachment 81404 [details] [review] Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again We must not encode & again and use the url filter, instead of uri. To test: - Search for a record in staff - Go to holds - Search for patrons, multiple should be displayed - Pick a patron by clicking on the name - Verify an error is shown and the URL is incorrect - Apply patch - Repeat test above, placing a hold should now work. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Tiny change - switching to PQA right away. Thx Jonathan!
Downgrading severity a bit as searches with one result will work.
Awesome work all! Pushed to master for 18.11
Caused by bug 13618 not in 18.05.x series.