Bug 21713 - ExpireReservesonHolidays not obeying calendar
Summary: ExpireReservesonHolidays not obeying calendar
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-29 13:18 UTC by Kelly McElligott
Modified: 2023-10-08 00:38 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2018-10-29 13:18:25 UTC
If a library has the system preference, ExpireReservesonHolidays set to Don't Allow - and a library has set their calendar to have the day the hold is set to expire as a holiday, the hold will still show the date the library is closed as the expiration date.  The calendar is not being considered although the system preference says to obey the calendar. 

This was found in Koha version 17.11.07, 17.11.10 and in 18.05.02.
Comment 1 Kelly McElligott 2018-10-29 13:26:00 UTC
This expiration date is set when the item has been changed to waiting. 

Steps:

1. System preference : expirereservesonholidays to DON't Allow
2. Make sure the Koha calendar is closed on the day the item will expire if triggered today.
3.  Place a hold on a item and check it in to trigger the hold to Waiting.
4.  See that the waiting hold date is the date the Koha calendar has indicated as being closed.
Comment 2 Katrin Fischer 2018-10-29 22:24:34 UTC
IIRC this is only used by the cronjob, it won't cancel when the library is closed. Have you checked ExcludeHolidaysFromMaxPickUpDelay?
Comment 3 Kelly McElligott 2018-10-30 23:45:28 UTC
Yes Katrin that would be a good system preference to use for a work around, however, if the library does not want to give the patron all the days they are closed included in their reservesmaxpickupdelay

Although the cron does not remove the hold, it is misleading to the staff to see that a hold "could" cancel on a day that the library is actually closed. This date is also shown in the OPAC to display the patron when their hold has expired.
Comment 4 Katrin Fischer 2018-10-31 06:20:57 UTC
So maybe we should remove ExpireReservesOnHolidays and add a third option to ExcludeHolidaysFromMaxPickupDelay, making things work like useDaysMode?
Comment 5 Kelly McElligott 2018-10-31 11:58:54 UTC
Yes Katrin, that is a great idea!  Giving them ALL the options!
Comment 6 Andrew Fuerste-Henry 2021-07-07 15:32:15 UTC
(In reply to Katrin Fischer from comment #4)
> So maybe we should remove ExpireReservesOnHolidays and add a third option to
> ExcludeHolidaysFromMaxPickupDelay, making things work like useDaysMode?

+1 on this, ExcludeHolidaysFromMaxPickupDelay should have a "push to the next open day" option.