I'm getting the following warning from the QA script: missing_filter at line 15 ( <div style="white-space:pre">[% record | xml %]</div>) I clearly do have an xml filter there. Josef has said it's because it's missing from t::lib::QA::TemplateFilters.
There another question on top of this: Do we wan't to enable all built-in template toolkit filters by default? And so add them to test? http://template-toolkit.org/docs/manual/Filters.html
Closing this due to age
Reopening, if it's still valid we should fix it.
(In reply to Jonathan Druart from comment #3) > Reopening, if it's still valid we should fix it. I just did a quick test and it looks like it's still valid: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL filters missing_filter at line 17 (<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | xml %][% ELSE %]Koha online[% END %] catalog</title>) However, it's not 100% clear to me how to fix this one. I can write a patch which fixes this problem, but there might be other places in the script that need updating too? I don't know.
Created attachment 173850 [details] [review] Bug 21731: Try to fix filter detection in QA script for xml filter This change adds support for the "xml" filter to the QA script. Test plan: 1. Change a "html" filter in opac-main.tt to use "xml" instead, and temporarily commit your change 2. Run "qa" script 3. Notice it fails 4. Apply the BZ patch 5. Run "qa" script 6. Note that it passes now 7. Sign off the BZ patch and only upload it (and not your temporary commit which you can delete after)
(In reply to Josef Moravec from comment #1) > There another question on top of this: Do we wan't to enable all built-in > template toolkit filters by default? And so add them to test? > > http://template-toolkit.org/docs/manual/Filters.html Valid question, why 'xml'? We don't use it.
The comment is incorrect.