To recreate (with strict mode enabled)
1 - Pull up a patron's fines tab
2 - Add a manual fine
3 - Select type 'Copier fees'
4 - Try to add the fine
DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'accounttype' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125
at /usr/share/perl5/DBIx/Class/Exception.pm line 77
The problem is that this comes form MANUAL_INV, where you have to put the description in the authorised value (the code...) to make it show up correctly. It's always been used as accounttype, but the field is too short.
So at the moment, it will be shortened to fit in... no longer with strict mode.
I think we can't use one hard coded account type for all MANUAL_INV entries, as libraries need to be able to tell them apart (ILL fee from copier fees...)
So what can we do?
It should be handled the same way payment types are. A hardcoded generic accounttype and then a debit_type
I am not sure how that works, can you give an example?
And will it fix the no code but only a lengthy description issue?
There is now a dedicated debit_types table and handling to optionally enable/disable types for manual invoices.