Line 300 of orderreceive.tt has a typo: <input type="text" size="20" name="unitprice" id="unitprice" value="[% unitprice | $Price on_editing => 1 | html %]" /> <span lass="hint">[% IF (invoiceincgst == 1) %](tax inclusive)[% ELSE %](tax exclusive)[% END %]</span> Note the 'lass' instead of 'class'
Created attachment 82796 [details] [review] Bug 21929: Fix typo lass -> class Test plan: - Apply patch - Load orderreceive.pl => TEST: Observe that the Unit Price hint has the "hint" class CSS applied
The patch doesn't apply. Git shows this : fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt). error: could not build fake ancestor
Apologies Pierre-Marc, a mistake on my part. I'm about to attach a fixed patch.
Created attachment 82821 [details] [review] Bug 21929 - Typo in orderreceive.tt lass -> class
Test plan: - Apply patch - Load orderreceive.pl => TEST: Observe that the Unit Price hint has the "hint" class CSS applied
Created attachment 82836 [details] [review] Bug 21929 - Typo in orderreceive.tt lass -> class Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 82837 [details] [review] Bug 21929: Typo in orderreceive.tt lass -> class Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fixed qa tools warn: * Commit title does not start with 'Bug XXXXX: ' - b54d50a
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.02
backported to 18.05 for 18.05.08
Depends on Bug 21387 not in 17.11.x