To recreate: 1 - Define a report like: SELECT barcode, itemnumber FROM items WHERE (homebranch = <<Branch|branches>> AND 0 ) OR <<Branch|branches>>=<<Branch|branches>> 2 - Run it, you get results 3 - Select 'Rows to display' 50 4 - No results
Created attachment 83138 [details] [review] Bug 21991: Pass param names to report limit tool To test: 1 - Define a report like: SELECT barcode, itemnumber FROM items WHERE (homebranch = <<Branch|branches>> AND 0 ) OR <<Branch|branches>>=<<Branch|branches>> 2 - Run it, you get results 3 - Select 'Rows to display' 50 4 - No results 5 - Apply patch 6 - Run report 7 - Change display rows 8 - Results remain!
Created attachment 83141 [details] [review] Bug 21991: Pass param names to report limit tool To test: 1 - Define a report like: SELECT barcode, itemnumber FROM items WHERE (homebranch = <<Branch|branches>> AND 0 ) OR <<Branch|branches>>=<<Branch|branches>> 2 - Run it, you get results 3 - Select 'Rows to display' 50 4 - No results 5 - Apply patch 6 - Run report 7 - Change display rows 8 - Results remain! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 83155 [details] [review] Bug 21991: Pass param names to report limit tool To test: 1 - Define a report like: SELECT barcode, itemnumber FROM items WHERE (homebranch = <<Branch|branches>> AND 0 ) OR <<Branch|branches>>=<<Branch|branches>> 2 - Run it, you get results 3 - Select 'Rows to display' 50 4 - No results 5 - Apply patch 6 - Run report 7 - Change display rows 8 - Results remain! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple and works.. passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.01
For 18.05 fails QA test with the following message: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt SKIP filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/Asset.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206.
backported to 18.05 for 18.05.08
Pushed to 17.11.x for 17.11.14
Depends on Bug 9634 not in 17.11.x