Currently RecordedBooks circulation throws an error on the user account page for 'SPINNER_THROBBER' undefined The param is not passed to the template on that page - rather than passing it we should make the checks in the template
Created attachment 83279 [details] [review] Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense
I tested this patch with my RB credentials. The searching works and my account syncs up correctly on opac-recordedbooks-search.pl -- I can check out items, place holds, check in items, etc. from those results. opac-user.pl is still throwing the SPINNER_THROBBER error, and I still don't see content in the RB Account tab. Applying the patch causes this string to appear at the very bottom of opac-user.pl, both with valid and invalid RBdigital credentials set in the sysprefs: var SPINNER_THROBBER = "/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif"; I had to scroll down slightly to see it. Inspecting the html shows that string listed among the other scripts but without any tags, like this: <script src="/opac-tmpl/bootstrap/js/tags_18.1200017.js"></script> var SPINNER_THROBBER = "/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif"; <script src="/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min_18.1200017.js"></script>
Created attachment 88378 [details] [review] Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense
(In reply to Jason Robb from comment #2) Added missing script tags, thanks!
Created attachment 88775 [details] [review] Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 89056 [details] [review] Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06
missing dependencies, wont backport to 18.05.x