If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message.
Created attachment 83694 [details] [review] Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100
*** Bug 21745 has been marked as a duplicate of this bug. ***
Created attachment 83709 [details] [review] Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov>
Created attachment 83737 [details] [review] Bug 22076 - SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov>
Created attachment 83738 [details] [review] Bug 22076 - Fix the same situation for lost items Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov>
Created attachment 83739 [details] [review] Bug 22076 - Add missing whitespace on if statments
* Commit title does not start with 'Bug XXXXX: ' - 8ab6da3438 * Commit title does not start with 'Bug XXXXX: ' - f1d99e01d1 * Commit title does not start with 'Bug XXXXX: ' - e79dbc7dbc Please adjust yourself now. This is required for a longer time already ;)
Created attachment 87000 [details] [review] Bug 22076: SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov> Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87001 [details] [review] Bug 22076: Fix the same situation for lost items Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov> Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87002 [details] [review] Bug 22076: Add missing whitespace on if statments Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87003 [details] [review] Bug 22076: SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov> Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87004 [details] [review] Bug 22076: Fix the same situation for lost items Signed-off-by: Geeta Halley <ghalley@roundrocktexas.gov> Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87005 [details] [review] Bug 22076: Add missing whitespace on if statments Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Patches rescued and QA run done.. Passing QA
Awesome work all! Pushed to master for 19.05
Bug with enhancement not in 18.11.x series.