Bug 22077 - Uncaught JS Console errors
Summary: Uncaught JS Console errors
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-07 17:58 UTC by Martin Renvoize
Modified: 2019-03-16 00:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22077: Make sure there were not JS errors on running selenium tests (1.40 KB, patch)
2019-03-16 00:22 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2019-01-07 17:58:42 UTC
Bug 21813 resolves an uncaught JS console error which was introduced after the mass move of JS to the footer.

I'd love to see some sort of regression test to catch such errors in the future.. but I'm not sure how to proceed and didn't want to prevent that bug from progressing.. hence the new report here.
Comment 1 David Cook 2019-01-08 00:00:13 UTC
(In reply to Martin Renvoize from comment #0)
> I'd love to see some sort of regression test to catch such errors in the
> future.. but I'm not sure how to proceed and didn't want to prevent that bug
> from progressing.. hence the new report here.

Do you mean an automated test? I'd be intrigued by that.
Comment 2 Jonathan Druart 2019-03-16 00:22:41 UTC
Created attachment 86700 [details] [review]
Bug 22077: Make sure there were not JS errors on running selenium tests

We could move that code to t::lib::Selenium and add the subtest to all
our selenium/*.t files
Comment 3 Jonathan Druart 2019-03-16 00:25:26 UTC
However https://github.com/mozilla/geckodriver/issues/284