Bug 22105 - opac-detail hides place hold link when items list hidden
Summary: opac-detail hides place hold link when items list hidden
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Target Milestone: ---
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-11 17:06 UTC by Christopher Brannon
Modified: 2019-01-11 19:04 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Place hold link missing (71.58 KB, image/png)
2019-01-11 17:06 UTC, Christopher Brannon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2019-01-11 17:06:57 UTC
Created attachment 83814 [details]
Place hold link missing

If the item list is too large when opening the opac-detail.pl page, the list is hidden, with a link to view.  But while the list is hidden, the Place hold link is hidden.
Comment 1 Owen Leonard 2019-01-11 18:06:41 UTC
OPAC detail page doesn't know that the "place hold" link can be shown unless it has parsed all the items on the record. In the "too many items" case, the items are not parsed.


Assuming we're not parsing all the items on the record in order to gain some speed, I don't know how to solve that other than to always show the hold link when there are too many items and risk that the hold can't be placed
Comment 2 Christopher Brannon 2019-01-11 19:04:49 UTC
I don't think it would be a huge loss to have the link always show.  Patrons will figure it out on the next page.  It's the lesser of two evils in this case.  Let the patron find out on the next page rather than confuse the patron as to why they can't find the hold link.