When the CurrencyFormat is set to FR the amount of an adjustment will display with decimal comma. Changing 1,00 to 1,10 will save as 1.00.
Created attachment 84028 [details] [review] Bug 22110: Fix editing of adjustments for CurrencyFormat != US When using CurrencyFormat FR or CH the editing an amount behave badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. At the moment Koha only understands decimal dot, not comma. So every time data is entered, we use decimal dot. 1) Add an adjustment to an invoice 2) Change system preference CurrencyFormat to FR or CH 3) Verify the amount displays with a decimal comma 4) Try changing the amount to something like 1,11 5) Save the amount 6) Verify it shows 1.00 7) Apply patch 8) Refresh the invoice page if necessary 9) Verify amount is now shown as 1.00 10) Repeat test, use 1.11 11) Verify it will be stored correctly.
Created attachment 84161 [details] [review] Bug 22110: Fix editing of adjustments for CurrencyFormat != US When using CurrencyFormat FR or CH the editing an amount behave badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. At the moment Koha only understands decimal dot, not comma. So every time data is entered, we use decimal dot. 1) Add an adjustment to an invoice 2) Change system preference CurrencyFormat to FR or CH 3) Verify the amount displays with a decimal comma 4) Try changing the amount to something like 1,11 5) Save the amount 6) Verify it shows 1.00 7) Apply patch 8) Refresh the invoice page if necessary 9) Verify amount is now shown as 1.00 10) Repeat test, use 1.11 11) Verify it will be stored correctly. Signed-off-by: Mackey Johnstone <mackeyfj@gmail.com>
Created attachment 84221 [details] [review] Bug 22110: Fix editing of adjustments for CurrencyFormat != US When using CurrencyFormat FR or CH the editing an amount behave badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. At the moment Koha only understands decimal dot, not comma. So every time data is entered, we use decimal dot. 1) Add an adjustment to an invoice 2) Change system preference CurrencyFormat to FR or CH 3) Verify the amount displays with a decimal comma 4) Try changing the amount to something like 1,11 5) Save the amount 6) Verify it shows 1.00 7) Apply patch 8) Refresh the invoice page if necessary 9) Verify amount is now shown as 1.00 10) Repeat test, use 1.11 11) Verify it will be stored correctly. Signed-off-by: Mackey Johnstone <mackeyfj@gmail.com> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com>
Created attachment 84881 [details] [review] Bug 22110: Fix editing of adjustments for CurrencyFormat != US When using CurrencyFormat FR or CH the editing an amount behave badly. Example: changing displayed 1,00 to 1,11 would save as 1,00. At the moment Koha only understands decimal dot, not comma. So every time data is entered, we use decimal dot. 1) Add an adjustment to an invoice 2) Change system preference CurrencyFormat to FR or CH 3) Verify the amount displays with a decimal comma 4) Try changing the amount to something like 1,11 5) Save the amount 6) Verify it shows 1.00 7) Apply patch 8) Refresh the invoice page if necessary 9) Verify amount is now shown as 1.00 10) Repeat test, use 1.11 11) Verify it will be stored correctly. Signed-off-by: Mackey Johnstone <mackeyfj@gmail.com> Signed-off-by: mikael <mikael.Olangcay-Brisebois@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix to a silly oversight. No regressions Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
missing dependency, wont backport to 18.05.x