Created attachment 83835 [details] [review] Bug 22113: Add price formatting on item lost report The item lost report displays the price and replacement price for lost items. With the patch they will display according to the CurrencyFormat system preference. To test: - Mark 1 or more items lost - Make sure that replacement cost and purchase price are set - Go to Reports > Items lost - Search for your lost items - Verify price and replacement price display - Apply patch and toggle CurrencyFormat to different settings - Refresh lost items report - Verify prices are always displayed according to syspref setting
Created attachment 83923 [details] [review] Bug 22113: Add price formatting on item lost report The item lost report displays the price and replacement price for lost items. With the patch they will display according to the CurrencyFormat system preference. To test: - Mark 1 or more items lost - Make sure that replacement cost and purchase price are set - Go to Reports > Items lost - Search for your lost items - Verify price and replacement price display - Apply patch and toggle CurrencyFormat to different settings - Refresh lost items report - Verify prices are always displayed according to syspref setting Signed-off-by: Olivia Lu <olivialokm@gmail.com>
Hi Olivia, please leave assignee as the patch writer. If you change by accident, you can see it it looking at "History" or looking at the author line of the patch. Thx for your sign off! :)
Created attachment 84229 [details] [review] Bug 22113: Add price formatting on item lost report The item lost report displays the price and replacement price for lost items. With the patch they will display according to the CurrencyFormat system preference. To test: - Mark 1 or more items lost - Make sure that replacement cost and purchase price are set - Go to Reports > Items lost - Search for your lost items - Verify price and replacement price display - Apply patch and toggle CurrencyFormat to different settings - Refresh lost items report - Verify prices are always displayed according to syspref setting Signed-off-by: Olivia Lu <olivialokm@gmail.com> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com>
Created attachment 84268 [details] [review] Bug 22113: Add price formatting on item lost report The item lost report displays the price and replacement price for lost items. With the patch they will display according to the CurrencyFormat system preference. To test: - Mark 1 or more items lost - Make sure that replacement cost and purchase price are set - Go to Reports > Items lost - Search for your lost items - Verify price and replacement price display - Apply patch and toggle CurrencyFormat to different settings - Refresh lost items report - Verify prices are always displayed according to syspref setting Signed-off-by: Olivia Lu <olivialokm@gmail.com> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
pushed to 18.05.x for 18.05.09
Pushed to 17.11.x for 17.11.15