To reproduce: Go to Tools -> Import patrons Look under Notes There should be NO note talking about the patron_attributes field. Go to Administration -> system preferences Enable the ExtendedPatronAttributes syspref Go back to Tools -> Import patrons Notice the note still hasn't shown up, but it is meant to. This is because it is not checking the system preference correctly The code says [% IF ( ExtendedPatronAttributes ) %] but it should say [% IF ( Koha.Preference('ExtendedPatronAttributes') ) %]
Created attachment 84042 [details] [review] Bug 22136: Added 'ExtendedPatronAttributes' notes to 'Import Patrons' notes.
Hi Ethan, please take another look here, I tihnk something has gone wrong: - [% IF ( Koha.Preference('ExtendedPatronAttributes') == 1 ) %] + [% IF ( Koha.Preference(''tronAttributes) == 1 ) %]
Created attachment 84156 [details] [review] Bug 22136: Added 'ExtendedPatronAttributes' notes to 'Import Patrons' notes. Fixed ExtendedPatronAttributes typo.
Created attachment 84217 [details] [review] Bug 22136: Added 'ExtendedPatronAttributes' notes to 'Import Patrons' notes. Fixed ExtendedPatronAttributes typo. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 84242 [details] [review] Bug 22136: Added 'ExtendedPatronAttributes' notes to 'Import Patrons' notes. Fixed ExtendedPatronAttributes typo. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
Pushed to 18.05.x for 18.05.09
Depends on Bug 12598 not in 17.11.x