Bug 22145 - Add a syspref to hide the 'rows per page' dropdown when running a report
Summary: Add a syspref to hide the 'rows per page' dropdown when running a report
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jasmine Amohia
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2019-01-16 20:27 UTC by Aleisha Amohia
Modified: 2020-12-15 21:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 22145: Created syspref to hide/show 'rows per page' from reports print layout (4.89 KB, patch)
2019-01-16 20:35 UTC, Jasmine Amohia 		Details | Diff | Splinter Review
Fixed patch (3.69 KB, patch)
2019-09-16 16:44 UTC, Paul Hoffman 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2019-01-16 20:27:58 UTC 
When your report has very few results, this dropdown just takes up space.
Comment 1 Jasmine Amohia 2019-01-16 20:35:28 UTC 
Created attachment 84086 [details] [review]
Bug 22145: Created syspref to hide/show 'rows per page' from reports print layout

Test Plan:
1. Update the database
2. Find reportRowsPerPage syspref and confirm it is set to Show by default
3. In another tab, make a new report to run or run an existing report
4. Confirm that rows per page dropdown shows
5. Change syspref to Don't show
6. Refresh report tab and confirm that rows per page dropdown doesn't
show.
Comment 2 Pierre-Marc Thibault 2019-01-18 19:37:36 UTC 
I followed the test plan and all seemed to work, but when I checked the QA test, it failed :

<<<<<
 FAIL	installer/data/mysql/sysprefs.sql
   OK	  git manipulation
   FAIL	  semicolon
		simicolon found instead of comma at line 483
   OK	  sysprefs_order

 OK	koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
   OK	  filters
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  spelling
   OK	  tt_valid
   OK	  valid_template
>>>>>

Therefore, I set the Failed QA status until.
Comment 3 Paul Hoffman 2019-09-16 16:44:18 UTC 
Created attachment 92837 [details] [review]
Fixed patch

Changed the problematic semicolon to a comma