Using CurrencyFormat FR: When paying an amount the amount now shows with comma decimal instead of decimal dot. This creates big issues when trying to pay amounts correctly. For example: Trying to pay 9,55. Go into the input field and change 9 to 5, Koha will turn it into 555.00. Prices currently need to all be displayed with decimal dot in input fields. Please fix urgently.
Hi Katrin, I cannot recreate: "Create manual invoice" with amount=9.55 "Pay fines" > "Pay amount" > "Collect from patron" 5.55 > Confirm I see "-5,55" in the table. https://snag.gy/KEMAIu.jpg
Heh, let me update my outdated local repo :)
Created attachment 85136 [details] [review] Bug 22301: (bug 11373 follow-up) Do not format amounts in inputs on_edition flag must be set when the Price plugin is used on inputs. Prices currently need to all be displayed with decimal dot in input fields. Test plan: Trying to pay 9,55. Go into the input field and change 9 to 5. Without this patch Koha will turn it into 555.00.
New QA check is going to be added, see https://gitlab.com/koha-community/qa-test-tools/issues/10
It changed on the fly in the form immediately after I went in and changed the number - might be a JavaScript thing on the form. I didn't save it.
Thx for fixing and so great to see you back!
Created attachment 85142 [details] [review] Bug 22301: (bug 11373 follow-up) Do not format amounts in inputs on_edition flag must be set when the Price plugin is used on inputs. Prices currently need to all be displayed with decimal dot in input fields. Test plan: Trying to pay 9,55. Go into the input field and change 9 to 5. Without this patch Koha will turn it into 555.00. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 85154 [details] [review] Bug 22301: (bug 11373 follow-up) Do not format amounts in inputs on_edition flag must be set when the Price plugin is used on inputs. Prices currently need to all be displayed with decimal dot in input fields. Test plan: Trying to pay 9,55. Go into the input field and change 9 to 5. Without this patch Koha will turn it into 555.00. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Passing QA.. annoyed I missed it the first time round testing.. Great to here we're going to start catching it with a qa check, thanks for that Jonathan.
Awesome work all! Pushed to master for 19.05
Bug not in 18.11.x, marking RESOLVED FIXED.