When a lost item is written off by the library, but later returned, Koha gives a credit for that item. To recreate: 1. Ensure "Refund lost item fee" is set to "Yes" in Circulation and Fine Rules. 2. Check out an item to a patron. 3. Mark item as lost. Replacement price should be added to their account. 4. Write off the fee. 5. Return the item. A refund is generated. A write off should not generate a refund in this situation. Is it possible this is related to Bug 19919 ?
The issue appears to be from incorrectly assigned 'accountno' in Koha::Account->pay 88 # We should remove accountno, it is no longer needed 89 my $last = $self->lines->search( 90 {}, 91 { order_by => 'accountno' } )->next(); 92 my $accountno = $last ? $last->accountno + 1 : 1; The default order is ASC, so we end up assigning the lowest here Then in C4::Circulation->_FixAccountForLostAndReturned 2387 # check for charge made for lost book 2388 my $accountlines = Koha::Account::Lines->search( 2389 { 2390 itemnumber => $itemnumber, 2391 accounttype => { -in => [ 'L', 'Rep', 'W' ] }, 2392 }, 2393 { 2394 order_by => { -desc => [ 'date', 'accountno' ] } 2395 } 2396 ); We order the lines by accountno to get the most recent, however, the numbers are wrong so we don't get the most recent payment or write off.
18.05 is officially end of life at this point and I believe this bug is fixed in more recent versions... certainly, accountno was removed in 19.05, though not backported to 18.11 as far as I'm aware.. at this point, I would suggest we close this bug recommend an upgrade to 19.05 or above.