We delete stuff when it has no bearing on the test at all as far as I can tell.. we shouldn't do that as all we're doing it adding an unnecessary db load and slowing down the tests.
Created attachment 85177 [details] [review] Bug 22349: Remove overzealous database deletions from test For no apparent reason a whole lot of data was being deleted inside a transaction for each of the subtests in Koha/Acquisitions/Booksellers.t This patch simply remove the deletions. To test, run the test before and after applying the patch and they should all continue to pass.. If you have a large number of booksellers, baskets, orders or subscriptions in your database you may also see an decrease in the time it takes to run the test.
Created attachment 85223 [details] [review] Bug 22349: Remove overzealous database deletions from test For no apparent reason a whole lot of data was being deleted inside a transaction for each of the subtests in Koha/Acquisitions/Booksellers.t This patch simply remove the deletions. To test, run the test before and after applying the patch and they should all continue to pass.. If you have a large number of booksellers, baskets, orders or subscriptions in your database you may also see an decrease in the time it takes to run the test. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 85233 [details] [review] Bug 22349: Remove overzealous database deletions from test For no apparent reason a whole lot of data was being deleted inside a transaction for each of the subtests in Koha/Acquisitions/Booksellers.t This patch simply remove the deletions. To test, run the test before and after applying the patch and they should all continue to pass.. If you have a large number of booksellers, baskets, orders or subscriptions in your database you may also see an decrease in the time it takes to run the test. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Good catch
Awesome work all! Pushed to master for 19.05