Bug 22366 - Web-based installer mentions PostgreSQL
Summary: Web-based installer mentions PostgreSQL
Status: RESOLVED DUPLICATE of bug 22527
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Hayley Pelham
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2019-02-19 08:17 UTC by Magnus Enger
Modified: 2019-04-08 23:29 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22366: Amended help text - Web Installer step2 (2.46 KB, patch)
2019-03-04 01:10 UTC, Hayley Pelham
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2019-02-19 08:17:03 UTC
koha-tmpl/intranet-tmpl/prog/en/modules/installer/step2.tt has these lines:

 36         <p>Need help? See manual for [% IF ( mysql ) %]
 37               <a href="http://dev.mysql.com/doc/refman/4.1/en/grant.html">MySQL</a>
 38            [% ELSE %]
 39               <a href="http://www.postgresql.org/docs/8.2/interactive/sql-createrole.html">PostgreSQL</a>
 40            [% END %]
 41         </p>

I just ran through an upgrade in the web-based installer, and saw the text "Need help? See manual for PostgreSQL". Maybe because I run on MariaDB? 

I know the goal is to be more db agnostic, but this message might be confusing to users.
Comment 1 Jonathan Druart 2019-02-19 13:32:39 UTC
Looks like it has been caused by
  commit 6596513d4b5e0d20ee6b68fadbee2e5841997115
  Bug 17942 - Update style of the web installer with Bootstrap 3

Because the test was:
-    [% IF dbms == 'mysql' %]<a href="https://dev.mysql.com/doc/refman/5.5/en/grant.html">
Comment 2 Hayley Pelham 2019-03-04 01:10:01 UTC
Created attachment 85971 [details] [review]
Bug 22366: Amended help text - Web Installer step2

On Step 2 of the Web Installer, the 'Need Help?' section refers to MySQL
documentation if the DB used is MySQL, or refers to PostgreSQL
documentation in all other cases. This patch removes the reference to
PostgreSQL and instead only displays the 'Need Help' text if the user's
database is MySQL.

To test:
When running the Web Installer, if you are using MySQL then text that
says Need Help? with a link to the documentation should be present. If
you are using anything else (PostgreSQL, MariaDB, etc.), this text and link should not be present.
Comment 3 Katrin Fischer 2019-04-08 23:29:03 UTC
Hi Hayley, I am sorry, but this is a duplicate to bug 22527 that has already been signed off. Could you take a look if you agree with the solution proposed there?

*** This bug has been marked as a duplicate of bug 22527 ***