Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link.
Created attachment 85879 [details] [review] Bug 22434: correct item callnumber search link Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link. Patch does not create an include for OPAC since callnumber search link is only in display without XSLT which will be obsolete. It juste corrects the filtering with uri instead of url. Test plan : 1) Create an item with callnumber : AAA&1(2)3 2) Check callnumber display and search link ar OK in : 3) Intranet : perform a search in catalog search that displays this item 4) Intranet : perform a search in cataloguing serach that displays this item 5) Intranet : Create a list that displays this item 6) OPAC without XSLT : perform a search in catalog search that displays this item 7) OPAC without XSLT : perform a group search in catalog search that displays this item
Hi, I've tested up until Step 7, all looks fine. Would you mind explaining what you mean in Step 7 when you say 'group search'? Cheers, Hayley
Patch tested with a sandbox, by Theodoros Theodoropoulos <theod@lib.auth.gr>
Created attachment 86132 [details] [review] Bug 22434: correct item callnumber search link Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link. Patch does not create an include for OPAC since callnumber search link is only in display without XSLT which will be obsolete. It juste corrects the filtering with uri instead of url. Test plan : 1) Create an item with callnumber : AAA&1(2)3 2) Check callnumber display and search link ar OK in : 3) Intranet : perform a search in catalog search that displays this item 4) Intranet : perform a search in cataloguing serach that displays this item 5) Intranet : Create a list that displays this item 6) OPAC without XSLT : perform a search in catalog search that displays this item 7) OPAC without XSLT : perform a group search in catalog search that displays this item Signed-off-by: Theodoros Theodoropoulos <theod@lib.auth.gr>
The proposed patch seems to work with the latest master (as of today) and with minor changes can be backported to 17.xx Thanks Fridolin for taking time to work on this issue.
Could you explain the issue you are trying to fix? Without the patch: I have an item with its callnumber set to AAA&1(2)3 I launch a search and see a link /catalogue/search.pl?idx=callnum&q=%22AAA%261(2)3%22 I click on it and I am redirected to the bibliographic detail page.
(In reply to Hayley Mapley from comment #2) > Hi, > > I've tested up until Step 7, all looks fine. Would you mind explaining what > you mean in Step 7 when you say 'group search'? > > Cheers, > Hayley Hayley, you need to create a library group (Home › Administration › Library groups) with the "Use for staff search groups" feature, then on the advanced search form you will see it at the bottom of the page ("Groups of libraries").
(In reply to Jonathan Druart from comment #7) > (In reply to Hayley Mapley from comment #2) > > Hi, > > > > I've tested up until Step 7, all looks fine. Would you mind explaining what > > you mean in Step 7 when you say 'group search'? > > > > Cheers, > > Hayley > > Hayley, you need to create a library group (Home › Administration › Library > groups) with the "Use for staff search groups" feature, then on the advanced > search form you will see it at the bottom of the page ("Groups of > libraries"). Thanks for letting me know Jonathan!
(In reply to Jonathan Druart from comment #6) > Could you explain the issue you are trying to fix? > > Without the patch: > I have an item with its callnumber set to AAA&1(2)3 > I launch a search and see a link > /catalogue/search.pl?idx=callnum&q=%22AAA%261(2)3%22 > I click on it and I am redirected to the bibliographic detail page. Using idx=callnum will use all search options like the auto-trunction for example, that is useless in this case. Many places like the facets prefer <index>:<query>. This is also good for ES. And some places where missing the double quotes.
I tried rebasing this one for QA but found a couple of cases where I wasn't 100% sure of the intention as as such have deferred it back to "Patch doesn't apply"
Oh but I don't remember adding [ and ] Needs rework.
(In reply to Fridolin SOMERS from comment #11) > Oh but I don't remember adding [ and ] > Needs rework. Ahhhh [ is for [, because its part of the TT syntaxe [% ... In the end this change is not very usefull, i close.