So, one of the peculiarities of DateTime maths is that 12 plus 1 doesn't always equal 13 ;) This calls for an example (using 'limit' for end_of_month mode): 2019-01-31 + 1 month = 2019-02-28 2019-01-31 + 13 months = 2020-02-29 (this one maintains 'end of month' over the leap year) 2019-02-28 + 12 months = 2020-02-28 Koha does the third case but the test is currently setup for the second. 'dateexpiry'
Created attachment 85973 [details] [review] Bug 22443: Increase test coverage of get_expiry_date This method did not test for 'special' dates, i.e. handling for leap years. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85974 [details] [review] Bug 22443: Increase test coverage of get_expiry_date This method did not test for 'special' dates, i.e. handling for leap years. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Did not see the patch on bug 22443? :-/
Did not see the patch on bug 22446? :-/
Switched to in discussion, see related bug report.
I agree with Jonathan.. think we should close this one as a duplicate. *** This bug has been marked as a duplicate of bug 22446 ***