It is possible that request properties have been supplied prior to the copyright notice stage being reached, for example using the OpenURL submission function provided by the FreeForm backend. As such, any request parameters are lost since the "Yes" acceptance button on the copyright notice does not pass any parameters forward.
Created attachment 86184 [details] [review] Bug 22464: Pass forward parameters This patch ensures that parameters that are present are passed forward when accepting the copyright notice. Test plan: - Clone the latest version of the FreeForm backend from: https://github.com/PTFS-Europe/koha-ill-freeform - Ensure the ILLModuleCopyrightClearance syspref is populated - Create an OpenURL in order to pre-populate the FreeForm form, a suitable URL would be: <your_koha_instance>/cgi-bin/koha/opac-illrequests.pl?openurl=true&backend=FreeForm&method=create&opac=1&atitle=Theater%20careers.%20%5Belectronic%20resource%5D%20%3A%20a%20realistic%20guide.&aulast=Donahue%2C%20Tim&date=2012&genre=article&isbn=978123123123&issn=1234-5678&issue=34&pages=12-34&sid=EBSCO%3AAthlone%20Institute%20of%20Technology%3Aait.101326&title=article%20title%20here&volume=12 - Log in - Accept the copyright notice => TEST: Observe that the FreeForm form is pre-filled with the metadata supplied in the OpenURL
Created attachment 88214 [details] [review] Bug 22464: Pass forward parameters This patch ensures that parameters that are present are passed forward when accepting the copyright notice. Test plan: - Clone the latest version of the FreeForm backend from: https://github.com/PTFS-Europe/koha-ill-freeform - Ensure the ILLModuleCopyrightClearance syspref is populated - Create an OpenURL in order to pre-populate the FreeForm form, a suitable URL would be: <your_koha_instance>/cgi-bin/koha/opac-illrequests.pl?openurl=true&backend=FreeForm&method=create&opac=1&atitle=Theater%20careers.%20%5Belectronic%20resource%5D%20%3A%20a%20realistic%20guide.&aulast=Donahue%2C%20Tim&date=2012&genre=article&isbn=978123123123&issn=1234-5678&issue=34&pages=12-34&sid=EBSCO%3AAthlone%20Institute%20of%20Technology%3Aait.101326&title=article%20title%20here&volume=12 - Log in - Accept the copyright notice => TEST: Observe that the FreeForm form is pre-filled with the metadata supplied in the OpenURL Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Just want to note that this is very helpful: https://wiki.koha-community.org/wiki/ILL_backends Also the About page shows ILL backend config problems, which is very useful and I didn't know before.
Created attachment 88289 [details] [review] Bug 22464: Pass forward parameters This patch ensures that parameters that are present are passed forward when accepting the copyright notice. Test plan: - Clone the latest version of the FreeForm backend from: https://github.com/PTFS-Europe/koha-ill-freeform - Ensure the ILLModuleCopyrightClearance syspref is populated - Create an OpenURL in order to pre-populate the FreeForm form, a suitable URL would be: <your_koha_instance>/cgi-bin/koha/opac-illrequests.pl?openurl=true&backend=FreeForm&method=create&opac=1&atitle=Theater%20careers.%20%5Belectronic%20resource%5D%20%3A%20a%20realistic%20guide.&aulast=Donahue%2C%20Tim&date=2012&genre=article&isbn=978123123123&issn=1234-5678&issue=34&pages=12-34&sid=EBSCO%3AAthlone%20Institute%20of%20Technology%3Aait.101326&title=article%20title%20here&volume=12 - Log in - Accept the copyright notice => TEST: Observe that the FreeForm form is pre-filled with the metadata supplied in the OpenURL Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.
OK, I've had a chat with Andrew and he's informed me this isn't actually dependant on 18589 at all in reality.. it was just marked that way to prevent too much work rebasing the enhancements tree. As such, I'll backport this one this morning before releasing 18.11.05
Pushed to 18.11.x for 18.11.05