With bug 5371 we fixed OPAC pages to not show a former patron's details when using the back button in the browser. I noticed that not all pages are using force_no_caching => 1 now, notably opac-illrequests.pl doesn't appear to use it, some others like opac-suggestions neither. I think we should check if that is ok or if we need to fix files again. Can't confirm right now if it works ok all over.
Created attachment 86858 [details] [review] Bug 22542: Force back button to display personal data This is a follow-up of bug 5371 The following command must not return anything: grep ^output_html_with_http_headers `git grep -l -P "authnotrequired\s*=>\s*0" opac`|grep -v force_no_caching This must be a test somehwere to prevent further regressions.
Created attachment 87907 [details] [review] Bug 22542: Force back button to display personal data This is a follow-up of bug 5371 The following command must not return anything: grep ^output_html_with_http_headers `git grep -l -P "authnotrequired\s*=>\s*0" opac`|grep -v force_no_caching This must be a test somehwere to prevent further regressions. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Should we make the same change for other pages as well? Thinking of, but not sure, as those pages don't require login necessarily: opac-password-recovery opac-registration-verify opac-suggestions
Created attachment 87974 [details] [review] Bug 22542: Force back button to display personal data This is a follow-up of bug 5371 The following command must not return anything: grep ^output_html_with_http_headers `git grep -l -P "authnotrequired\s*=>\s*0" opac`|grep -v force_no_caching This must be a test somehwere to prevent further regressions. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Pushed to 18.11.x for 18.11.05
Pushed to 18.05.x for 18.05.12 Pushed to 17.11.x for 17.11.18
Awesome work all! Pushed to master for 19.05