Koha/EDI.pm - $basket->effective_create_item (Missing the 's'), which will cause Koha::Objects to throw an 'The method is untested' error whenever his codepath is followed.
Created attachment 87225 [details] [review] Bug 22611: Correction for typo in Koha::EDI A typo in Koha::EDI leads to 'The method is not tested' errors to be thrown when the codepath is taken and can lead to subsequent data corruption. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 87271 [details] [review] patch to make test consistent with initial copy In addition to the typo, the patch used a different call to for subsequent copies to the initial copy. That could create confusion in the future
Created attachment 87326 [details] [review] Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 87327 [details] [review] Bug 22611: Correction for call to get create_item in EDI.pm There was a typo in the addition of a call to effective_create_items causing processing to abort after adding a single copy. This patch reverts to using the C4::Context call as used for the first copy created, the intended call to effective_create_items is a wrapper around that as the field in the basket is guaranteed to be null (its not set when we call AddBasket). Being consistent and explicit in what we call should guard against future changes in dependencies exposing the logic flaw Added some comments to make logical flow of code clearer Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment on attachment 87225 [details] [review] Bug 22611: Correction for typo in Koha::EDI Sorry I'm making a lot of noise >.<
Created attachment 87333 [details] [review] Bug 22611: Correction for call to get create_item in EDI.pm There was a typo in the addition of a call to effective_create_items causing processing to abort after adding a single copy. This patch reverts to using the C4::Context call as used for the first copy created, the intended call to effective_create_items is a wrapper around that as the field in the basket is guaranteed to be null (its not set when we call AddBasket). Being consistent and explicit in what we call should guard against future changes in dependencies exposing the logic flaw Added some comments to make logical flow of code clearer Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
backported to 18.05.x for 18.05.12
Looks like its not needed for 17.11.x