(In reply to Jonathan Druart from comment #373) > CREATE TABLE statements do not follow the usual pattern: > > CREATE TABLE IF NOT EXISTS stockrotationitems > vs > DROP TABLE IF EXISTS `circulation_rules`; > CREATE TABLE `circulation_rules` (
Created attachment 87373 [details] [review] Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql The existing pattern is: DROP TABLE IF EXISTS ... CRATE TABLE Stockrotation was using: CREATE TABLE IF NOT EXISTS ... which would not recreate the table in a database it's already existing in possibly causing mismatches in table structure. To test: - Drop your database - Run through the web installer - Make sure there are no Database/SQL errors - Makse sure the 4 stockrotation tables have been created
Created attachment 87482 [details] [review] Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql The existing pattern is: DROP TABLE IF EXISTS ... CRATE TABLE Stockrotation was using: CREATE TABLE IF NOT EXISTS ... which would not recreate the table in a database it's already existing in possibly causing mismatches in table structure. To test: - Drop your database - Run through the web installer - Make sure there are no Database/SQL errors - Makse sure the 4 stockrotation tables have been created Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Thanks Frederic!
Created attachment 87507 [details] [review] Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql The existing pattern is: DROP TABLE IF EXISTS ... CRATE TABLE Stockrotation was using: CREATE TABLE IF NOT EXISTS ... which would not recreate the table in a database it's already existing in possibly causing mismatches in table structure. To test: - Drop your database - Run through the web installer - Make sure there are no Database/SQL errors - Makse sure the 4 stockrotation tables have been created Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for beating me to this Katrin and Frederic.. PQA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
missing dependency, wont backport to 18.05.x