See bug 21336. This is now arranged by using the same column login_attempts. login_attempts > pref_value means locked login_attempts < 0 means admin lock Do we need one or even two new columns? [1] locked: regular lock (resulting from entering wrong password), boolean replacing the check attempts > pref. Note that changing the pref might lock or unlock users now. Do we want that? [2] admin_locked: administrative lock, resulting from e.g. removing GDPR consent, boolean
Any more feedback, Jonathan?
I think we could have only 1 more column: the reason of the lock. If NULL, the account is not locked. The field could be an ENUM with the different reasons.
I think that changing the pref resulting in unlocking users makes sense to me. You might figure out you don't want to use the feature after all, so setting a high value will help. Having 2 columns will allow to have an administrative lock and a too_many_attempts lock at the same time... but it makes me wonder if we could just have 1 new column for the administrative lock as boolean? And keep the failed_attempts behaviour.