We use a readonly CodeMirror display for the SQL reports' "view" page. We should do the same for the SQL view which is shown on the report results page, triggered by the "Show SQL code" button.
Created attachment 89370 [details] [review] Bug 22856: Show SQL code button should trigger CodeMirror view This patch adds CodeMirror syntax highlighting to the SQL view which can be shown on the report results page by clicking the "Show SQL code" button. To test, apply the patch and run any SQL report. On the report results page, click the "Show SQL button." The SQL should be displayed with CodeMirror syntax highlighting. Test toggling the SQL code view on and off to confirm that the CodeMirror highlighting continues to work correctly.
Created attachment 89371 [details] [review] Bug 22856: Show SQL code button should trigger CodeMirror view This patch adds CodeMirror syntax highlighting to the SQL view which can be shown on the report results page by clicking the "Show SQL code" button. To test, apply the patch and run any SQL report. On the report results page, click the "Show SQL button." The SQL should be displayed with CodeMirror syntax highlighting. Test toggling the SQL code view on and off to confirm that the CodeMirror highlighting continues to work correctly. Signed-off-by: Barton Chittenden <barton@bywatersolutions.com>
Created attachment 89415 [details] [review] Bug 22856: Show SQL code button should trigger CodeMirror view This patch adds CodeMirror syntax highlighting to the SQL view which can be shown on the report results page by clicking the "Show SQL code" button. To test, apply the patch and run any SQL report. On the report results page, click the "Show SQL button." The SQL should be displayed with CodeMirror syntax highlighting. Test toggling the SQL code view on and off to confirm that the CodeMirror highlighting continues to work correctly. Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I think this could fall under 'polishing' the Code mirror work in this release :) It's nice, maybe the text area is a little big for a tiny report.
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series