Bug 22882 - ItemType translation modal is not consistent with other modals
Summary: ItemType translation modal is not consistent with other modals
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 8290 17835
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-10 09:46 UTC by Martin Renvoize
Modified: 2019-10-05 07:45 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22882: ItemType translation modal is not consistent with other modals (5.28 KB, patch)
2019-10-04 14:53 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2019-05-10 09:46:21 UTC
The translation modal for item type translations isn't consistent with other modals visually.
Comment 1 Owen Leonard 2019-10-04 14:53:20 UTC
Created attachment 93748 [details] [review]
Bug 22882: ItemType translation modal is not consistent with other modals

This patch modifies the itemtypes administration template replacing in
the translation process the Greybox modal with a Bootstrap modal.

To test you should have at least one translation enabled.

 - Apply the patch and go to Administration -> Item types.
 - Edit an existing item type.
 - Click the "Translate into other languages" link by the "Description"
   field.
   - A Bootstrap-styled modal should appear.
   - Test the process of adding and deleting a translation.
   - Test hiding and redisplaying the modal dialog.
Comment 2 Lucas Gass 2019-10-04 16:53:07 UTC
When I delete a translation it works but it also simultaneously displays:

<div class="dialog message">The translation (id *) has been removed successfully</div>

AND 

<div class="dialog alert">An error occurred when deleting this translation</div>


They both disappear after about 3 or 4 seconds. Not sure whats going on here.