Checing marc21 loc rules I have seen some issues with out xslt templates 1. Fields 020 and 022 should not inclue ending '.' 2. Field 300 should not include '.' if 300$c is cm or mm On the other hand I am not sure if there is a rule on 100$e to be published between [relator] thanks!
I think the end user doesn't need the . and it is more irritating then helpful, especially since we are very inconsistent in printing it. I think either we rely on libraries adding the punctuation or let Koha add it, but mixing both is not good. I suggest to remove the . where we are currently displaying it.
Created attachment 89624 [details] [review] Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line.
It seems silly to fail QA for one full stop, but.... This patch appears to work for all the MARC fields listed in comment 2 on the Intranet, but on the OPAC there is a full stop on the Series section (440) after 'Name of part/section of a work' (not sure if that's because it's the last value listed or because of that particular field).
Created attachment 90702 [details] [review] Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail
Hi Hayley, thx for testing so well! It appears it was fixed in staff, but I forgot to remove it in OPAC. Could you have another look please?
Created attachment 90760 [details] [review] Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 90761 [details] [review] Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
A little contribution: Tag 440 is obsolete in MARC21. It should be replaced by tag 490 as the default "series statement fields" in a fresh installation. See: http://www.loc.gov/marc/bibliographic/bd4xx.html
Thank you, Hayley!
(In reply to Katrin Fischer from comment #9) > Thank you, Hayley! No prob Katrin :)
Created attachment 90927 [details] [review] Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com>
Created attachment 90928 [details] [review] Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com>
After these patches if you have a 440 and a 490 in the record they have no space between. I mean, you probably shouldn't have both, but I have seen stranger things
Hi Nick, this is a tricky one... I'll have a look.
Should we keep the . separator or would some other thing like ; look nicer?
Created attachment 92143 [details] [review] Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff
(In reply to Nick Clemens from comment #13) > After these patches if you have a 440 and a 490 in the record they have no > space between. > > I mean, you probably shouldn't have both, but I have seen stranger things Follow-up added, thx for testing Nick!
Created attachment 92203 [details] [review] Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 92204 [details] [review] Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 92205 [details] [review] Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 92206 [details] [review] Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 93559 [details] [review] Bug 22884: Remove field ending . from XSLT templates Currently Koha very inconsistently adds a . at the end when outputting MARC fields on the detail views. This patch removes the few cases where we add in . Keeping the end user in mind, I believe it's not needed and the added consistency will be nice. ISBD should be added on cataloguing or by templates, but we should not mix when possible. To test: Catalog the following fields, if repeatable, add more than one: - 020 - 022 - 111 - 242 - 245 - 246 - 250 - 300 - 440 - 490 - 700/710/711 with $i - 700/710/711 ind.2 = 2 Verify both on staff and OPAC detail pages that there is no additional . at the end of the line. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 93560 [details] [review] Bug 22884: (follow-up) Remove ending . from 440 in OPAC detail Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: frederik <frederik@inlibro.com> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 93561 [details] [review] Bug 22884: Show separator between 440 and 490 fields This adds a ; as separator between 440 and 490 fields used in the same record. Currently we loop first 440 and then 490. 490 is displayed depending on the indicator. So after we finish the first loop, we check for existence of 490 on the same record now to decide if a separator is needed. To test: - Look at various records using one or multiple 440 and 490 fields - Verify the display is correct, especially when both appar on the same record in both OPAC and staff Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00