In backport of 21346 a few hidden inputs were lost in the conversion to modals
Created attachment 89667 [details] [review] Bug 22896: Missing inputs in transfer modal This patch restires hidden inputs to save overrideen checkin date in the checkin screen To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains
Created attachment 89670 [details] [review] Bug 22896: Missing inputs in transfer modal This patch restires hidden inputs to save overrideen checkin date in the checkin screen To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89671 [details] [review] Bug 22896: Missing inputs in transfer modal This patch restores hidden inputs to save overridden checkin date and other data Currently we lose the list of checkouts and several settings when items with transfers are checked in To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains
Created attachment 89672 [details] [review] Bug 22896: Missing inputs in transfer modal This patch restores hidden inputs to save overridden checkin date and other data Currently we lose the list of checkouts and several settings when items with transfers are checked in To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Can you explain a bit more what happened? I have compared the two commits and they are identical.
(In reply to Jonathan Druart from comment #5) > Can you explain a bit more what happened? I have compared the two commits > and they are identical. Ah, it looks like I just got my code misaligned and hit the wrong conditions during testing, this is a master issue too. Ultimately these variables should probably all be in a block, but I think we need to fix quickly for now
Created attachment 89825 [details] [review] Bug 22896: Missing inputs in transfer modal This patch restores hidden inputs to save overridden checkin date and other data Currently we lose the list of checkouts and several settings when items with transfers are checked in To test: 1 - Find an item from another branch 2 - Set a checkin date and click the box for the date to be remembered 3 - Check in the item 4 - Click ok or print, note the checkin date is lost 5 - Apply patch 6 - Repeat 7 - Checkin date remains Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I think this is rather important to have before release... it all works as expected for me here so I'm going to PQA. Note: It might be nice to have a regression test for this (selenium), but I'm not of the opinion it's required at this stage.
On second look, I think there's more to this.. there are a few more missing hidden form fields that got removed entirely in bug 21346 but still appear in returns.pl. I'm reverting my PQA until I've investigated further.
Right.. PQA. We've moved my worry points to a followup bug report and will fix them early next cycle.. This patch fixes the issue reported and moves us forward. Go forth and push Mr RM
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06
*** Bug 23062 has been marked as a duplicate of this bug. ***