Items search /cgi-bin/koha/catalogue/itemsearch.pl should be impacted by preference IndependentBranches. Maybe it should automatically limit to current branch. Main problem is that actually its a way to edit items of other branches. Maybe there should also be a check in cataloguing/additem.pl itself.
Auto-limiting with the option to still change it makes sense to me (so don't hide the search options, but preselect accordingly). They might want to check what of their items is at another location or vice versa. The edit buttons needs to be checked, but as we so often had problems with this already I think a check in additem would make a lot of sense.
(In reply to Katrin Fischer from comment #1) > The edit buttons needs to be checked Could we simply hide "Edit item" in IndependentBranches context ?
(In reply to Fridolin SOMERS from comment #2) > (In reply to Katrin Fischer from comment #1) > > The edit buttons needs to be checked > > Could we simply hide "Edit item" in IndependentBranches context ? I think we need to check the library matches the logged in one and keep edit links for those items. - If you just hide all of them it will take a away a major use case of the item search.
I do not understand. It seems that nothing block the edition, even with IndependentBranches turned on. The bug report should not focus on the item search but to fix globally the issue, if it is what you meant. If so, can you detail the condition of the edition please? * Superlibrarian can edit everything * librarian with editcatalogue can edit a biblio * librarian with editcatalogue and from the same library as holdingbranch or homebranch can edit an item We should then adjust all the links to item editing.
(In reply to Jonathan Druart from comment #4) > I do not understand. It seems that nothing block the edition, even with > IndependentBranches turned on. The bug report should not focus on the item > search but to fix globally the issue, if it is what you meant. Oh yes indeed. > > If so, can you detail the condition of the edition please? > > * Superlibrarian can edit everything > > * librarian with editcatalogue can edit a biblio > > * librarian with editcatalogue and from the same library as holdingbranch or > homebranch can edit an item Maybe we use to use HomeOrHoldingBranch ? Or create a new preference with allow edition depending on home/holding/both. > > We should then adjust all the links to item editing.
(In reply to Jonathan Druart from comment #4) > I do not understand. It seems that nothing block the edition, even with > IndependentBranches turned on. Oh but now I have tested : With IndependentBranches turned on, in record normal view, you see the "Edit" button only on the items of your branch. Pref says : Prevent staff (but not superlibrarians) from modifying objects (holds, items, patrons, etc.) belonging to other libraries.
(In reply to Fridolin SOMERS from comment #6) > (In reply to Jonathan Druart from comment #4) > > I do not understand. It seems that nothing block the edition, even with > > IndependentBranches turned on. > > Oh but now I have tested : > With IndependentBranches turned on, in record normal view, you see the > "Edit" button only on the items of your branch. > > Pref says : > Prevent staff (but not superlibrarians) from modifying objects (holds, > items, patrons, etc.) belonging to other libraries. Hum indeed, but you can "Edit items", then edit whichever you want...
(In reply to Jonathan Druart from comment #7) > Hum indeed, but you can "Edit items", then edit whichever you want... Ah when I test that I see in items table the "Actions" button only on my items.
*** This bug has been marked as a duplicate of bug 20256 ***