Bug 22923 - Items edition does not take care of independent branches
Summary: Items edition does not take care of independent branches
Status: RESOLVED DUPLICATE of bug 20256
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-16 11:10 UTC by Fridolin Somers
Modified: 2019-12-10 14:18 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2019-05-16 11:10:39 UTC
Items search /cgi-bin/koha/catalogue/itemsearch.pl should be impacted by preference IndependentBranches.
Maybe it should automatically limit to current branch.
Main problem is that actually its a way to edit items of other branches.

Maybe there should also be a check in cataloguing/additem.pl itself.
Comment 1 Katrin Fischer 2019-05-16 11:30:59 UTC
Auto-limiting with the option to still change it makes sense to me (so don't hide the search options, but preselect accordingly). They might want to check what of their items is at another location or vice versa. 

The edit buttons needs to be checked, but as we so often had problems with this already I think a check in additem would make a lot of sense.
Comment 2 Fridolin Somers 2019-05-22 09:40:24 UTC
(In reply to Katrin Fischer from comment #1)
> The edit buttons needs to be checked

Could we simply hide "Edit item" in IndependentBranches context ?
Comment 3 Katrin Fischer 2019-05-27 05:15:06 UTC
(In reply to Fridolin SOMERS from comment #2)
> (In reply to Katrin Fischer from comment #1)
> > The edit buttons needs to be checked
> 
> Could we simply hide "Edit item" in IndependentBranches context ?

I think we need to check the library matches the logged in one and keep edit links for those items. - If you just hide all of them it will take a away a major use case of the item search.
Comment 4 Jonathan Druart 2019-11-25 16:02:11 UTC
I do not understand. It seems that nothing block the edition, even with IndependentBranches turned on. The bug report should not focus on the item search but to fix globally the issue, if it is what you meant.

If so, can you detail the condition of the edition please?

* Superlibrarian can edit everything

* librarian with editcatalogue can edit a biblio

* librarian with editcatalogue and from the same library as holdingbranch or homebranch can edit an item

We should then adjust all the links to item editing.
Comment 5 Fridolin Somers 2019-11-26 09:02:17 UTC
(In reply to Jonathan Druart from comment #4)
> I do not understand. It seems that nothing block the edition, even with
> IndependentBranches turned on. The bug report should not focus on the item
> search but to fix globally the issue, if it is what you meant.
Oh yes indeed.

> 
> If so, can you detail the condition of the edition please?
> 
> * Superlibrarian can edit everything
> 
> * librarian with editcatalogue can edit a biblio
> 
> * librarian with editcatalogue and from the same library as holdingbranch or
> homebranch can edit an item
Maybe we use to use HomeOrHoldingBranch ? Or create a new preference with allow edition depending on home/holding/both.

> 
> We should then adjust all the links to item editing.
Comment 6 Fridolin Somers 2019-11-26 09:11:43 UTC
(In reply to Jonathan Druart from comment #4)
> I do not understand. It seems that nothing block the edition, even with
> IndependentBranches turned on.

Oh but now I have tested :
With IndependentBranches turned on, in record normal view, you see the "Edit" button only on the items of your branch.

Pref says :
Prevent staff (but not superlibrarians) from modifying objects (holds, items, patrons, etc.) belonging to other libraries.
Comment 7 Jonathan Druart 2019-11-26 09:41:51 UTC
(In reply to Fridolin SOMERS from comment #6)
> (In reply to Jonathan Druart from comment #4)
> > I do not understand. It seems that nothing block the edition, even with
> > IndependentBranches turned on.
> 
> Oh but now I have tested :
> With IndependentBranches turned on, in record normal view, you see the
> "Edit" button only on the items of your branch.
> 
> Pref says :
> Prevent staff (but not superlibrarians) from modifying objects (holds,
> items, patrons, etc.) belonging to other libraries.

Hum indeed, but you can "Edit items", then edit whichever you want...
Comment 8 Fridolin Somers 2019-11-28 11:00:04 UTC
(In reply to Jonathan Druart from comment #7)
> Hum indeed, but you can "Edit items", then edit whichever you want...

Ah when I test that I see in items table the "Actions" button only on my items.
Comment 9 Jonathan Druart 2019-12-10 14:18:39 UTC

*** This bug has been marked as a duplicate of bug 20256 ***