There is a markup error somewhere in the OPAC holds template (opac-reserve.tt) which is causing a validation error: - "Stray end tag div."
Created attachment 91018 [details] [review] Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors.
Created attachment 91019 [details] [review] Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes.
Created attachment 91295 [details] [review] Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 91296 [details] [review] Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 91360 [details] [review] Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Created attachment 91365 [details] [review] Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>
Created attachment 91366 [details] [review] Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>
Created attachment 91380 [details] [review] Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 91381 [details] [review] Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03
backported to 18.11.x for 18.11.09