Bug 22992 - When you merge records in a list there is no way to return to the list
Summary: When you merge records in a list there is no way to return to the list
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: axel Amghar
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-27 12:28 UTC by axel Amghar
Modified: 2021-04-01 14:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22992: Ability to return to the list when you merge records of a list (5.85 KB, patch)
2019-05-28 08:38 UTC, axel Amghar
Details | Diff | Splinter Review
Bug 22992: Ability to return to the list when you merge records of a list (5.85 KB, patch)
2019-05-29 07:41 UTC, axel Amghar
Details | Diff | Splinter Review
Bug 22992: Ability to return to the list when you merge records of a list (5.90 KB, patch)
2019-05-29 12:22 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description axel Amghar 2019-05-27 12:28:17 UTC
In a list, you can merge records but when you do it, there is no way to return to the list directly.
Comment 1 axel Amghar 2019-05-28 08:38:12 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2019-05-28 16:16:51 UTC
I see one very small issue: This breadcrumb link:

Contents of <i>[% shelf.name | uri %]</i>

...that should use the "html" filter instead of "uri"
Comment 3 axel Amghar 2019-05-29 07:41:37 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2019-05-29 12:22:20 UTC
Created attachment 90183 [details] [review]
Bug 22992: Ability to return to the list when you merge records of a list

Test plan:

Without the patch :
- Create 2 records
- Add them to the same list
- Go to the list and merge these two patrons
- In the nav bar you can't go back to the list

Apply the patch
- Now you should have a nav bar to return to the list
like that :https://snag.gy/cnWxa2.jpg
- Test every link of the nav bar, they should work
- Make all the merge process, and test the links on the 3 pages

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 axel Amghar 2019-05-29 12:30:59 UTC
Hello,
I just realized i wrote (in the test plan):
"Go to the list and merge these two patrons"
but i mean
"Go to the list and merge these two RECORDS"
sorry for the mistake
Comment 6 Marcel de Rooy 2019-05-31 09:00:28 UTC
+    %shelf = (
+        private => $input->param("shelf_private"),
+        name    => $input->param("shelfname"),
+        number  => $input->param("shelfnumber")
+    );

Axel,
Thanks for your patch!
I would recommend to pass only the shelfnumber via a CGI parameter in the URL. And get the Koha object for it in the script.
This allows you to better check what you receive. The other parameters could be misused when mangling URLs.