Bug 23009 - Add -deleted_marc_conditions argument to export_records script
Summary: Add -deleted_marc_conditions argument to export_records script
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Gustafsson
QA Contact: Testopia
URL:
Keywords:
Depends on: 20551
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-29 13:56 UTC by David Gustafsson
Modified: 2022-12-21 16:20 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 23009: Add -deleted_marc_conditions to export_records (10.17 KB, patch)
2019-05-29 14:21 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 23009: Add -set_deleted_marc_conditions to export_records (10.46 KB, patch)
2022-04-08 13:05 UTC, David Gustafsson
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Gustafsson 2019-05-29 13:56:40 UTC
At our library we need to be able to marc exported records for deletion depending on a marc conditions. This patch adds a new argument that provides that functionality. The tests t/db_dependent/Exporter/Record.t fails in current master, which is an issue when running the included tests, but it seems like an unrelated bug. I will look into it and create a separate issue regarding this.
Comment 1 David Gustafsson 2019-05-29 14:21:20 UTC
Created attachment 90189 [details] [review]
Bug 23009: Add -deleted_marc_conditions to export_records

Add -deleted_marc_conditions argument to export_records script
for setting deleted flag on records if condition matches.
Comment 2 David Gustafsson 2019-05-31 10:56:20 UTC
Regarding the bug causing the tests to fail it was just a mismatch of my current schema version and code base, so forget about that part :)
Comment 3 David Gustafsson 2022-04-08 13:05:18 UTC
Created attachment 133121 [details] [review]
Bug 23009: Add -set_deleted_marc_conditions to export_records

Add -set_deleted_marc_conditions argument to export_records script
for setting deleted flag on records if condition matches.

To test:

1) Run tests in t/db_dependent/Exporter/Record.t

Sponsored-by: Gothenburg University Library
Comment 4 David Gustafsson 2022-04-08 13:13:33 UTC
Rebased. Also renamed option to something more descriptive, the previous was pretty awful as you would probably expect the conditions be applied the same way as for normal records but for deleted ones. -set_deleted_marc_conditions will set the deleted flag for matching records, and are not conditions applied to filter records out as the previous parameter name implied.