When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches.
Created attachment 90322 [details] [review] Hide non-pickup branches from hold modification select When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches. Test plan: 1) Create a branch that is marked as a non-pickup location. 2) Create a hold or a patron. 3) Go to members/moremember.pl for that patron, check the Holds-tab Pickup library -drop down. It lists the non-pickup branch. 4) Go to reserve/request.pl for that biblio. The Existing hold-table Pickup library -drop down lists the non-pickup branch. 5) Apply patch. 6) Repeat 3 & 4, drop down no longer lists the non-pickup branch.
Created attachment 90429 [details] [review] Bug 23048: Hide non-pickup branches from hold modification select When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches. Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Actually, I'll withdraw the patch - when a reserve has a non-pickup library as a pickup location, it doesn't work correctly. (Perhaps the reserve was created before the library was marked as non-pickup-location)
Created attachment 91048 [details] [review] Bug 23048: Hide non-pickup branches from hold modification select When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches, unless the branch is marked as a pick-up branch for already existing hold. The reason for showing a non-pickup branch for the holds created before the branch was marked as non-pickup: If the non-pickup branch wasn't shown, the branch in those holds would get set to the first branch in the select if the hold was modified. Test plan: 1) Create a hold for a patron, to be picked up from a certain branch. 2) Edit the branch and another branch so they are no longer pickup locations. 3) Go to members/moremember.pl for that patron, check the Holds-tab Pickup library -drop down. It lists both of the non-pickup branches. 4) Go to reserve/request.pl for that biblio. The hold-table Pickup library -drop down lists both of the non-pickup branches. 5) Apply patch. 6) Repeat 3 & 4, drop down no longer lists the non-pickup branch, but should still list the branch where the hold was marked to be picked from.
Would this be the same as bug 7534, but for staff? Bug 7534 - New OPACAllowUserToChooseBranch setting for only showing libraries allowing holds
Created attachment 91453 [details] [review] Bug 23048: Hide non-pickup branches from hold modification select When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches, unless the branch is marked as a pick-up branch for already existing hold. The reason for showing a non-pickup branch for the holds created before the branch was marked as non-pickup: If the non-pickup branch wasn't shown, the branch in those holds would get set to the first branch in the select if the hold was modified. Test plan: 1) Create a hold for a patron, to be picked up from a certain branch. 2) Edit the branch and another branch so they are no longer pickup locations. 3) Go to members/moremember.pl for that patron, check the Holds-tab Pickup library -drop down. It lists both of the non-pickup branches. 4) Go to reserve/request.pl for that biblio. The hold-table Pickup library -drop down lists both of the non-pickup branches. 5) Apply patch. 6) Repeat 3 & 4, drop down no longer lists the non-pickup branch, but should still list the branch where the hold was marked to be picked from. Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Makes the behaviour more consistent and also takes care of existing holds. +1
Created attachment 91623 [details] [review] Bug 23048: Hide non-pickup branches from hold modification select When modifying holds in staff client via reserve/request.pl or the holds-tab in members/moremember.pl, the pickup library dropdown lists libraries not marked for pickup. Hide those branches, unless the branch is marked as a pick-up branch for already existing hold. The reason for showing a non-pickup branch for the holds created before the branch was marked as non-pickup: If the non-pickup branch wasn't shown, the branch in those holds would get set to the first branch in the select if the hold was modified. Test plan: 1) Create a hold for a patron, to be picked up from a certain branch. 2) Edit the branch and another branch so they are no longer pickup locations. 3) Go to members/moremember.pl for that patron, check the Holds-tab Pickup library -drop down. It lists both of the non-pickup branches. 4) Go to reserve/request.pl for that biblio. The hold-table Pickup library -drop down lists both of the non-pickup branches. 5) Apply patch. 6) Repeat 3 & 4, drop down no longer lists the non-pickup branch, but should still list the branch where the hold was marked to be picked from. Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Ideally, I would like to have seen a selenium regression test for this, but I'm not going to let it prevent push this cycle. Just a heads up that I may start getting more strict with these as the cycle progresses.
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03