Bug 23056 - Wrong path for fix_tags_weight.pl in updatedatabase.pl
Summary: Wrong path for fix_tags_weight.pl in updatedatabase.pl
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 21846
Blocks:
  Show dependency tree / graph
 
Reported: 2019-06-05 17:31 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2024-07-04 20:37 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2019-06-05 17:31:03 UTC 
The displayed path is wrong on non-dev setups.
This as introduced by bug 21846.
Comment 1 Katrin Fischer 2019-07-13 09:16:34 UTC 
There are other occurrences of the pattern in the updatedatabase script:

my $upgrade_script = C4::Context->config("intranetdir") . "/installer/data/mysql/labels_upgrade.pl";
my $upgrade_script = C4::Context->config("intranetdir") . "/installer/data/mysql/patroncards_upgrade.pl"

There are other places where we don't give a full path, which seems common in other places like the GUI as well:

print "If you have records with ean, please run misc/batchRebuildBiblioTables.pl to populate bibliotems.ean\n" if (C4::Context->preference("marcflavour") eq 'UNIMARC');

Would you be ok with changing it to the latter or can we make it work nicely for all installation types?
Comment 2 Katrin Fischer 2023-10-08 10:36:31 UTC 
This is quite old now, so harder to fix/test, maybe more something to keep in mind for the future?