In opac-reserve.pl click on 'Show more options' select 'A specific item' Then you'll see a table with a column 'Last location' (holdingbranch) always empty if homebranch = holdingbranch. It would be better if this column shows always this location. opac/opac-reserve.pl # If the holdingbranch is different than the homebranch, we show the # holdingbranch of the document too. if ( $itemInfo->{homebranch} ne $itemInfo->{holdingbranch} ) { $itemLoopIter->{holdingBranchName} = $itemInfo->{holdingbranch}; }
Created attachment 90453 [details] [review] Show holdingbranch whatever the case To test : Without patch 1° Choose an item available to hold with the same homebranch and holdingbranch 2° In opac-reserve.pl click on 'Show more options' 3° Select 'A specific item' 4° You'll see a table with column 'Last location' (holdingbranch) empty With patch 4° You'll see column 'Last location' (holdingbranch) filled thx
Created attachment 90863 [details] [review] Bug 23067: show the holdingbranch in opac-reserve Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 90864 [details] [review] Bug 23067: show the holdingbranch in opac-reserve Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Not sure about that change, I do not know what is supposed to tell "last location" in that case. Maybe a feature?
Adding some more librarians. My feeling is that 'last location' is confusing - if I understand correctly it won't always be empty, but only empty homebranch = holdingbranch. I suggest changing the column heading to "Current location" which matches how the item shows in the detail page and always display it, like Christophe's patch does it. Adding Liz and Owen for some thoughts.
(In reply to Katrin Fischer from comment #5) > I suggest changing the column heading to "Current location" which matches > how the item shows in the detail page and always display it, like > Christophe's patch does it. Agreed. Call it "current location" and always show it. I would also reorder the columns to match the detail page--current location followed by home location.
(In reply to Owen Leonard from comment #6) > (In reply to Katrin Fischer from comment #5) > > I suggest changing the column heading to "Current location" which matches > > how the item shows in the detail page and always display it, like > > Christophe's patch does it. > > Agreed. Call it "current location" and always show it. I would also reorder > the columns to match the detail page--current location followed by home > location. +1 Christophe, could you make those 2 additional changes? Column heading + sequence.
Hello Katrin, yes of course it is relevant. I will do a new patch soon regards