Bug 23067 - When confirming a hold in OPAC the last location column is empty
Summary: When confirming a hold in OPAC the last location column is empty
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Christophe Croullebois
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-06 14:53 UTC by Christophe Croullebois
Modified: 2019-11-13 23:48 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Show holdingbranch whatever the case (1.13 KB, patch)
2019-06-10 12:39 UTC, Christophe Croullebois
Details | Diff | Splinter Review
Bug 23067: show the holdingbranch in opac-reserve (1.18 KB, patch)
2019-06-20 17:21 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 23067: show the holdingbranch in opac-reserve (1.18 KB, patch)
2019-06-20 17:23 UTC, Mark Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Croullebois 2019-06-06 14:53:09 UTC
In opac-reserve.pl click on 'Show more options' select 'A specific item' 
Then you'll see a table with a column 'Last location' (holdingbranch) always empty if homebranch = holdingbranch.
It would be better if this column shows always this location.

opac/opac-reserve.pl

        # If the holdingbranch is different than the homebranch, we show the
        # holdingbranch of the document too.
        if ( $itemInfo->{homebranch} ne $itemInfo->{holdingbranch} ) {
            $itemLoopIter->{holdingBranchName} = $itemInfo->{holdingbranch};
        }
Comment 1 Christophe Croullebois 2019-06-10 12:39:49 UTC
Created attachment 90453 [details] [review]
Show holdingbranch whatever the case

To test :

Without patch
1° Choose an item available to hold with the same homebranch and holdingbranch
2° In opac-reserve.pl click on 'Show more options'
3° Select 'A specific item'
4° You'll see a table with column 'Last location' (holdingbranch) empty

With patch
4° You'll see column 'Last location' (holdingbranch) filled

thx
Comment 2 Mark Tompsett 2019-06-20 17:21:49 UTC
Created attachment 90863 [details] [review]
Bug 23067: show the holdingbranch in opac-reserve

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Mark Tompsett 2019-06-20 17:23:13 UTC
Created attachment 90864 [details] [review]
Bug 23067: show the holdingbranch in opac-reserve

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 4 Jonathan Druart 2019-06-24 17:28:17 UTC
Not sure about that change, I do not know what is supposed to tell "last location" in that case. Maybe a feature?
Comment 5 Katrin Fischer 2019-06-26 22:25:11 UTC
Adding some more librarians.

My feeling is that 'last location' is confusing - if I understand correctly it won't always be empty, but only empty homebranch = holdingbranch.

I suggest changing the column heading to "Current location" which matches how the item shows in the detail page and always display it, like Christophe's patch does it.

Adding Liz and Owen for some thoughts.
Comment 6 Owen Leonard 2019-06-27 11:58:51 UTC
(In reply to Katrin Fischer from comment #5)
> I suggest changing the column heading to "Current location" which matches
> how the item shows in the detail page and always display it, like
> Christophe's patch does it.

Agreed. Call it "current location" and always show it. I would also reorder the columns to match the detail page--current location followed by home location.
Comment 7 Katrin Fischer 2019-06-27 12:16:50 UTC
(In reply to Owen Leonard from comment #6)
> (In reply to Katrin Fischer from comment #5)
> > I suggest changing the column heading to "Current location" which matches
> > how the item shows in the detail page and always display it, like
> > Christophe's patch does it.
> 
> Agreed. Call it "current location" and always show it. I would also reorder
> the columns to match the detail page--current location followed by home
> location.

+1

Christophe, could you make those 2 additional changes? Column heading + sequence.
Comment 8 Christophe Croullebois 2019-06-27 12:29:25 UTC
Hello Katrin,

yes of course it is relevant.
I will do a new patch soon

regards