When using preference itemBarcodeFallbackSearch one can enter a search term instead of a barcode in checkout form. If on-site is selected this should be transmitted to itemBarcodeFallbackSearch form.
Created attachment 90781 [details] [review] Bug 23158: keep on-site checkout info when using itemBarcodeFallbackSearch When using preference itemBarcodeFallbackSearch one can enter a search term instead of a barcode in checkout form. If on-site is selected this should be transmitted to itemBarcodeFallbackSearch form. Test plan : 1) Enable system preferences "itemBarcodeFallbackSearch" and "OnSiteCheckouts" 2) Disable system preference "ConsiderOnSiteCheckoutsAsNormalCheckouts" 3) Go to a patron circulation page 4) Check "On-site checkout" in "Checkout settings" 5) Enter a barcode in checkout form and click on "Check out" 6) You see the checkout in table with red "(On-site checkout)" 7) Check "On-site checkout" in "Checkout settings" 8) Enter the title of a record in in checkout form and click on "Check out" 9) Click on "Checkout" on a line 10) You see the checkout in table with red "(On-site checkout)"
Created attachment 90935 [details] [review] Bug 23158: keep on-site checkout info when using itemBarcodeFallbackSearch When using preference itemBarcodeFallbackSearch one can enter a search term instead of a barcode in checkout form. If on-site is selected this should be transmitted to itemBarcodeFallbackSearch form. Test plan : 1) Enable system preferences "itemBarcodeFallbackSearch" and "OnSiteCheckouts" 2) Disable system preference "ConsiderOnSiteCheckoutsAsNormalCheckouts" 3) Go to a patron circulation page 4) Check "On-site checkout" in "Checkout settings" 5) Enter a barcode in checkout form and click on "Check out" 6) You see the checkout in table with red "(On-site checkout)" 7) Check "On-site checkout" in "Checkout settings" 8) Enter the title of a record in in checkout form and click on "Check out" 9) Click on "Checkout" on a line 10) You see the checkout in table with red "(On-site checkout)" Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com>
Created attachment 90959 [details] [review] Bug 23158: keep on-site checkout info when using itemBarcodeFallbackSearch When using preference itemBarcodeFallbackSearch one can enter a search term instead of a barcode in checkout form. If on-site is selected this should be transmitted to itemBarcodeFallbackSearch form. Test plan : 1) Enable system preferences "itemBarcodeFallbackSearch" and "OnSiteCheckouts" 2) Disable system preference "ConsiderOnSiteCheckoutsAsNormalCheckouts" 3) Go to a patron circulation page 4) Check "On-site checkout" in "Checkout settings" 5) Enter a barcode in checkout form and click on "Check out" 6) You see the checkout in table with red "(On-site checkout)" 7) Check "On-site checkout" in "Checkout settings" 8) Enter the title of a record in in checkout form and click on "Check out" 9) Click on "Checkout" on a line 10) You see the checkout in table with red "(On-site checkout)" Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 90960 [details] [review] Bug 23158: Make the assignment statement more readable Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work! Pushed to master for 19.11.00
(In reply to Jonathan Druart from comment #4) > Created attachment 90960 [details] [review] [review] > Bug 23158: Make the assignment statement more readable > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Oh sure, thanks a lot for that better code ;)
Pushed to 19.05.x for 19.05.03