Currently if viewing a framework each field has an actions dropdown: Subfields Edit Delete I think we should have: Edit tag View subfields Edit subfields Delete
Created attachment 90894 [details] [review] Bug 23179: Add 'edit subfields' button to framework management To test: 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) Note the dropdowns for each tag are: Edit, Subfields, Delete 4) Apply patch 5) Reload and note dropdowns are: Edit tag, View subfields, Edit subfields, Delete 6) Confirm options do what is selected
Created attachment 90933 [details] [review] Bug 23179: Add 'edit subfields' button to framework management To test: 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) Note the dropdowns for each tag are: Edit, Subfields, Delete 4) Apply patch 5) Reload and note dropdowns are: Edit tag, View subfields, Edit subfields, Delete 6) Confirm options do what is selected Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Created attachment 90970 [details] [review] Bug 23179: Add 'edit subfields' button to framework management To test: 1) Go to Administration > MARC bibliographic framework 2) On a line click Actions > MARC structure 3) Note the dropdowns for each tag are: Edit, Subfields, Delete 4) Apply patch 5) Reload and note dropdowns are: Edit tag, View subfields, Edit subfields, Delete 6) Confirm options do what is selected Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.02 Very small so I think it can go into stable branches.
This is a strange change in behaviour between 17.11 and 18.11. In 17.11: clicking on subfields leads to the 'summary' page of subfields with edit and delete buttons for each: /cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=000&frameworkcode= In 18.11: clicking on the subfields link leads to the edit screen and there is no link to the 'summary' page visible, which is a usability problem if you are trying ot delete a subfield. Can this please be backported to 18.11 as well?
(In reply to Katrin Fischer from comment #6) > This is a strange change in behaviour between 17.11 and 18.11. > > In 17.11: clicking on subfields leads to the 'summary' page of subfields > with edit and delete buttons for each: > /cgi-bin/koha/admin/marc_subfields_structure.pl?tagfield=000&frameworkcode= > > In 18.11: clicking on the subfields link leads to the edit screen and there > is no link to the 'summary' page visible, which is a usability problem if > you are trying ot delete a subfield. > > Can this please be backported to 18.11 as well? I think you describing bug 23153
> I think you describing bug 23153 Yes, I was confusing bugs - thx Nick!
backported to 18.11.x for 18.11.09