Bug 23235 - Rename Koha::Biblio->metadata with ->marc_xml to avoid ambiguity
Summary: Rename Koha::Biblio->metadata with ->marc_xml to avoid ambiguity
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 22700
Blocks:
  Show dependency tree / graph
 
Reported: 2019-06-28 18:17 UTC by Jonathan Druart
Modified: 2023-10-05 10:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2019-06-28 18:17:36 UTC 
What about renaming the method in Koha::S::R::Biblio to ->marc_xml_metadata (adding the conditions in it) and Koha::Biblio->metadata to ->marc_xml (make it returns the MARX XML directly)?

See bug 22700 for the discussion.

However it will break (again) the reports people already have.
Comment 1 Tomás Cohen Arazi (tcohen) 2019-06-28 18:19:43 UTC 
It should return a Koha::Biblio::Metadata object, which is an envelope containing info about the schema, format, etc. Maybe you mean a method in Koha::Biblio::Metadata
Comment 2 Jonathan Druart 2019-06-28 18:55:14 UTC 
The problem IMO is that we have a DB structure to allow 1-N but it's not clear (reading the code) that we support only one.
I think we should have "marc_xml" explicitely written in the name of the subroutine, to make it clear.

Reading the code I'd say that even if you have a biblio_metadata.format with something else than "marcxml", it will be used anyway.