Bug 21582 removed htmlarea in favour or textarea in the system preferences. However 5 instances of html area remain one in circulation.pref and 4 in staff_client.pref This renders those 5 systempreferences uneditable.
Created attachment 91521 [details] [review] Proposed patch
Created attachment 91526 [details] [review] Bg 23315 : Some systempreferences can not be edited To test 1/ Go to systempreferences 2/ Notice that SelfCheckHelpMessage IntranetmainUserblock IntranetCirculationHomeHTML IntranetReportsHomeHTML StaffLoginInstructions are not editable 3/ Apply patch, refresh page 4/ Now they can be edited Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 91527 [details] [review] Bug 23315: (follow-up) Add configuration to enable CodeMirror This patch adds the "syntax" parameter to the corrected system preferences so that the textareas will be displayed as CodeMirror editors. To test, apply the patch and test the affected system preferences: Circulation -> SelfCheckHelpMessage Staff client -> IntranetmainUserblock Staff client -> IntranetCirculationHomeHTML Staff client -> IntranetReportsHomeHTML Staff client -> StaffLoginInstructions With UseWYSIWYGinSystemPreferences disabled, the preferences should be displayed as CodeMirror editors. With UseWYSIWYGinSystemPreferences enabled they should be WYSIWYG editors.
Created attachment 91541 [details] [review] Bug 23315 : Some systempreferences can not be edited To test 1/ Go to systempreferences 2/ Notice that SelfCheckHelpMessage IntranetmainUserblock IntranetCirculationHomeHTML IntranetReportsHomeHTML StaffLoginInstructions are not editable 3/ Apply patch, refresh page 4/ Now they can be edited Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 91542 [details] [review] Bug 23315: (follow-up) Add configuration to enable CodeMirror This patch adds the "syntax" parameter to the corrected system preferences so that the textareas will be displayed as CodeMirror editors. To test, apply the patch and test the affected system preferences: Circulation -> SelfCheckHelpMessage Staff client -> IntranetmainUserblock Staff client -> IntranetCirculationHomeHTML Staff client -> IntranetReportsHomeHTML Staff client -> StaffLoginInstructions With UseWYSIWYGinSystemPreferences disabled, the preferences should be displayed as CodeMirror editors. With UseWYSIWYGinSystemPreferences enabled they should be WYSIWYG editors. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 91611 [details] [review] Bug 23315 : Some systempreferences can not be edited To test 1/ Go to systempreferences 2/ Notice that SelfCheckHelpMessage IntranetmainUserblock IntranetCirculationHomeHTML IntranetReportsHomeHTML StaffLoginInstructions are not editable 3/ Apply patch, refresh page 4/ Now they can be edited Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 91612 [details] [review] Bug 23315: (follow-up) Add configuration to enable CodeMirror This patch adds the "syntax" parameter to the corrected system preferences so that the textareas will be displayed as CodeMirror editors. To test, apply the patch and test the affected system preferences: Circulation -> SelfCheckHelpMessage Staff client -> IntranetmainUserblock Staff client -> IntranetCirculationHomeHTML Staff client -> IntranetReportsHomeHTML Staff client -> StaffLoginInstructions With UseWYSIWYGinSystemPreferences disabled, the preferences should be displayed as CodeMirror editors. With UseWYSIWYGinSystemPreferences enabled they should be WYSIWYG editors. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.03
not needed in 18.11.x, no backport