branch_transfer_limits.pl uses DBI SQL statements in the controller. Replace those with Koha::Objects. change branchcode to fromBranch to clarify what is the purpose of the branchcode. Prepare for more BranchTransferLimit authorised value limiting types.
Created attachment 91604 [details] [review] Bug 23342 - Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics branch_transfer_limits.pl uses DBI SQL statements in the controller. Replace those with Koha::Objects. change term 'branchcode' to 'fromBranch' to clarify what is the purpose of the branchcode. Prepare for more BranchTransferLimit authorised value limiting types. Sponsored-by: The National Library of Finland
Hi there, can you please provide a test plan?
Doesn't apply anymore and would have to be split into separate patches for each individual change described in the patch message as this patch combines multiple changes.