Bug 23342 - Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics
Summary: Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix var...
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on: 23343
Blocks: 23344
  Show dependency treegraph
 
Reported: 2019-07-18 16:47 UTC by Olli-Antti Kivilahti
Modified: 2022-09-07 01:38 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 23342 - Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics (8.72 KB, patch)
2019-07-18 17:52 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2019-07-18 16:47:46 UTC
branch_transfer_limits.pl uses DBI SQL statements in the controller.
Replace those with Koha::Objects.

change branchcode to fromBranch to clarify what is the purpose of the branchcode.

Prepare for more BranchTransferLimit authorised value limiting types.
Comment 1 Olli-Antti Kivilahti 2019-07-18 17:52:04 UTC
Created attachment 91604 [details] [review]
Bug 23342 - Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics

branch_transfer_limits.pl uses DBI SQL statements in the controller.
Replace those with Koha::Objects.

change term 'branchcode' to 'fromBranch' to clarify what is the purpose of the branchcode.

Prepare for more BranchTransferLimit authorised value limiting types.

Sponsored-by: The National Library of Finland
Comment 2 Aleisha Amohia 2021-01-10 23:36:27 UTC
Hi there, can you please provide a test plan?
Comment 3 Joonas Kylmälä 2022-09-05 19:55:51 UTC
Doesn't apply anymore and would have to be split into separate patches for each individual change described in the patch message as this patch combines multiple changes.